Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spaces in dataset names #11

Closed
wlhlm opened this issue Jul 25, 2023 · 1 comment · Fixed by #12
Closed

Support spaces in dataset names #11

wlhlm opened this issue Jul 25, 2023 · 1 comment · Fixed by #12

Comments

@wlhlm
Copy link

wlhlm commented Jul 25, 2023

While not explicitly documented, it is possible (and supported by core ZFS and utilities) to create ZFS datasets with spaces in them (see openzfs/zfs#1027 for a small discussion). zfs-periodic fails to support such datasets due to use of simplistic shell variable splitting using the default IFS which splits on spaces. Example from the code:

datasets=$(zfs list -r -H -o name $pool)
# ...
for dataset in $datasets; do

I've noticed this only after 4 years of using zfs-periodic that one of my ZFS filesystems wasn't snapshotting properly. 😅

Please consider supporting such datasets.

@ross
Copy link
Owner

ross commented Jul 26, 2023

PRs welcome. I don't really have a great setup atm for developing/testing zfs-periodic so it'll be a while before I'd get a chance to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants