Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-dawn: Rewrite of Dawn Hearing Map in Table Form #3927

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

theatischbein
Copy link
Contributor

Doing a rewrite of the luci dawn hearing map in fancy table form.

Screenshot_2020-04-18_10-12-22-2

Thanks to @PolynomialDivision for the work

Signed-off-by: Jonny Tischbein <jonny_tischbein@systemli.org>
@theatischbein theatischbein marked this pull request as ready for review April 18, 2020 08:28
@PolynomialDivision
Copy link
Member

Looks awesome! Thank you.

Please merge, since I do not have merge permissions.

@dibdot
Copy link
Contributor

dibdot commented Apr 18, 2020

@jonnytischbein
Has this been tested with all LuCI standard themes?
Why do we still use deprecated table-syntax with hardcoded styles?
I would suggest to better use the common div-structure with a separate css file, e.g.

<div class="cbi-section-node">
	<div class="table" id="...">
		<div class="tr table-titles">
			<div class="th"><%:...%></div>
			<div class="th"><%:...%></div>
			<div class="th"><%:...%></div>
[...]

@theatischbein
Copy link
Contributor Author

theatischbein commented Apr 18, 2020

Originally I wanted to use something like bootstrap grids but I didn't know that there are classes like that.

I'll try to replace it

@theatischbein
Copy link
Contributor Author

Works good so far.

@dibdot Do you know if there is an equivalent to rowspan ? I didn't found something like that in the css file.
Is there documentation for the div table ?

Signed-off-by: Jonny Tischbein <jonny_tischbein@systemli.org>
@theatischbein
Copy link
Contributor Author

Current changes with div tables
I don't know which other themes I should test. Where can I choose them ?

Screenshot_2020-04-18_12-36-57-2

@dibdot
Copy link
Contributor

dibdot commented Apr 18, 2020

themes
@jonnytischbein that looks much better - many thanks!
The theme selection is placed in the system menu, at least you should test Bootstrap (most probably already done), OpenWrt & OpenWrt2020.

Thanks again for your efforts!

@theatischbein
Copy link
Contributor Author

Thanks! In my build only bootstrap is availalble and was used for develpoping.

@dibdot
Copy link
Contributor

dibdot commented Apr 18, 2020

Just install the other themes with opkg (luci-theme-*)

@PolynomialDivision
Copy link
Member

looksawesome

Looks awesome! :)

@dibdot
Copy link
Contributor

dibdot commented Apr 18, 2020

OK then, let's merge it.

@dibdot dibdot merged commit 44ee223 into openwrt:master Apr 18, 2020
@PolynomialDivision
Copy link
Member

Let's see if I can convert the other page to "div-structure with a separate css file", too. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants