Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-app-babeld: Bug/Feature request: Make interface readable #6337

Closed
marek22k opened this issue Apr 11, 2023 · 4 comments
Closed

luci-app-babeld: Bug/Feature request: Make interface readable #6337

marek22k opened this issue Apr 11, 2023 · 4 comments

Comments

@marek22k
Copy link
Contributor

marek22k commented Apr 11, 2023

Steps to reproduce:

  1. go to: Status → Babeld tab
  2. look at the status

Actual behavior:

A very ugly site. I think the whole thing is supposed to be a table, but it is not.

Expected behavior:

Something clear - for example, a table.

Additional Information:

I use the Luci Design OpenWrt2020. I have attached pictures.

OpenWrt version information from system /etc/openwrt_release

DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='22.03.3'
DISTRIB_REVISION='r20028-43d71ad93e'
DISTRIB_TARGET='ramips/mt76x8'
DISTRIB_ARCH='mipsel_24kc'
DISTRIB_DESCRIPTION='OpenWrt 22.03.3 r20028-43d71ad93e'
DISTRIB_TAINTS=''

You can see a page on which headings are placed one below the other. Below are the values, but one heading/value per line. Nothing is formatted.

Ping on maintainers: @jonnytischbein @PolynomialDivision @aparcar
(I am sorry if I am pinging you and you are not the maintainers, however there is nothing in the files about this and you are in the commit history).

@marek22k
Copy link
Contributor Author

I think https://github.com/openwrt/luci/blob/master/applications/luci-app-babeld/root/www/luci-static/resources/babeld.js#L38 is supposed to be a table. However, div elements are used for this. Maybe that is the reason for the appearance?

@marek22k
Copy link
Contributor Author

For the Bootstrap and OpenWrt themes, a table actually appears.

@theatischbein
Copy link
Contributor

At first it was build using the table tag (see #3927 (comment) ) but changed to the "common div structure" because table appears to be deprecated.

The theme does not seem to support this: https://github.com/openwrt/luci/blob/openwrt-22.03/themes/luci-theme-openwrt-2020/htdocs/luci-static/openwrt2020/cascade.css
Maybe @jow- knows something about it ?

@marek22k
Copy link
Contributor Author

marek22k commented Apr 13, 2023

Why is table deprecated? As far as I know, the element still exists in HTML5. (https://stackoverflow.com/questions/17503456/is-it-good-to-use-tables-in-html-5)

The comment, to my understanding, gives little conclusion about the reasons why LuCi has its own table classes instead of using native HTML elements.

@jow- jow- closed this as completed in 70fb460 Apr 28, 2023
jow- added a commit that referenced this issue Apr 28, 2023
Fixes: #6337
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 70fb460)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants