-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-app-babeld: Bug/Feature request: Make interface readable #6337
Comments
I think https://github.com/openwrt/luci/blob/master/applications/luci-app-babeld/root/www/luci-static/resources/babeld.js#L38 is supposed to be a table. However, div elements are used for this. Maybe that is the reason for the appearance? |
For the Bootstrap and OpenWrt themes, a table actually appears. |
At first it was build using the table tag (see #3927 (comment) ) but changed to the "common div structure" because table appears to be deprecated. The theme does not seem to support this: https://github.com/openwrt/luci/blob/openwrt-22.03/themes/luci-theme-openwrt-2020/htdocs/luci-static/openwrt2020/cascade.css |
Why is table deprecated? As far as I know, the element still exists in HTML5. (https://stackoverflow.com/questions/17503456/is-it-good-to-use-tables-in-html-5) The comment, to my understanding, gives little conclusion about the reasons why LuCi has its own |
Steps to reproduce:
Actual behavior:
A very ugly site. I think the whole thing is supposed to be a table, but it is not.
Expected behavior:
Something clear - for example, a table.
Additional Information:
I use the Luci Design OpenWrt2020. I have attached pictures.
OpenWrt version information from system
/etc/openwrt_release
Ping on maintainers: @jonnytischbein @PolynomialDivision @aparcar
(I am sorry if I am pinging you and you are not the maintainers, however there is nothing in the files about this and you are in the commit history).
The text was updated successfully, but these errors were encountered: