-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dobot #927
Dobot #927
Conversation
* Add GitPython to requirements/base.txt Fixes openvinotoolkit#905 (should this go in `base.txt`, or `extras.txt`?) * Moved GitPython requirement from base to extra
…otoolkit/anomalib into dobot
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -47,45 +47,31 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #23. image_name = str(Path(f"{path}" + "/input_" + str(now.strftime("%Y%m%d%H%M%S")) + ".jpg"))
Reply via ReviewNB
@@ -47,45 +47,31 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #29. image_name = str(Path(f"{path}" + "/input_" + str(now.strftime("%Y%m%d%H%M%S")) + ".jpg"))
Reply via ReviewNB
@@ -47,45 +47,31 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -37,7 +37,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to show the output of the cells, I suggest to show just the config file, and the image of one cube and the images with results.
Reply via ReviewNB
GitPython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is this line from git.repo import Repo
which requires gitpython
f77d3b1
into
openvinotoolkit:feature/notebooks/usecases/dobot
* Use case Dobot - WIP commit (#884) * WIP commit * training via config file and robot control * 2 notebooks robot control * Removed utils directory from notebooks/500_use_cases * Removed utils directory from `notebooks/500_use_cases` (#911) Removed utils directory from notebooks/500_use_cases * Download the dataset and the api from anomalib assets * adding readme file * adding instructions * adding instructions * adding instructions * adding instructions * adding instructions * adding instructions * adding instructions * adding instructions * adding instructions * adding instructions * Update README.md * Model training is done via API now * Fixed the bugs spotted by Paula * directories for robot * adding robot/training notebooks (#926) * adding robot/training notebooks * normalization issue fixed * adding imagenet for OV inferencing * Remove unused header * Add new line at the end of file * Fix dataset path * Fix formatting --------- Co-authored-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com> * Dobot (#927) * Add GitPython to requirements/base.txt (#906) * Add GitPython to requirements/base.txt Fixes #905 (should this go in `base.txt`, or `extras.txt`?) * Moved GitPython requirement from base to extra * adding robot/training notebooks * Modify notebooks * Run pre-commit * stash changes * Refactor files + delete old * Removve checkponit * Revert header * Address PR comments * Remove output --------- Co-authored-by: Paula Ramos <paula.ramos@intel.com> Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com> * Move requirements + ignore dobot notebooks --------- Co-authored-by: Paula Ramos <paula.ramos@intel.com> Co-authored-by: Samet <samet.akcay@intel.com> Co-authored-by: Ashwin Vaidya <ashwinitinvaidya@gmail.com>
Description