-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizer show classification and segmentation #178
Visualizer show classification and segmentation #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr, would you be able to resolve the merge conflicts so we could run the CI?
Ah right! Just want to note that after merging this PR #181 the proposed solution needs to be updated.. |
@alexriedel1, the CI has been fixed now. Could you please update the PR by pulling the latest development? Thanks! |
done |
I merged the development branch and fixed some styling errors |
@alexriedel1, we've run the CI. There are two tests that failed unexpectedly. We'll have a look why this is the case, and let you know. I don't expect you to look the tests:) Here is the CI log showing why it failed: |
It's because the class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the efforts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for another nice contribution. I just have some minor comments
This would be a possible fix to #175 (comment)
Alternatively, the classification image could always be added as it provides useful insights in what the model predicted.