Cross-compile libraries #190
Conversation
lucacome
commented
Sep 10, 2021
•
- Cross-compile libraries leveraging helper tools from https://github.com/tonistiigi/xx
- Remove gRPC build (doesn't seem to be used)
- Build plugin directly for zipkin, jaeger and datadog
- Avoid building unnecessary files for jaeger
12ec679 to
2941bf2
Compare
|
Well, my main goal (other than supporting s390x) was to improve building time but seems like gRPC still takes forever. What is it needed for? |
|
As I remember it was used for some of the adpater Lightstep or Jaeger. |
|
Ah yeah seems like it’s required for Lightstep (even though not in the latest version). Should I disable the build for now since Lightstep is not being built and the other tracer don’t use it (it’s in a different stage that non of the other use)? |
|
@lucacome There is also zipkin-cpp that requires grpc: https://github.com/flier/zipkin-cpp/blob/master/CMakeLists.txt#L58 |
|
Interesting, it wasn't complaining when I tried to disable the build for gRPC... |
|
@miry I think that's a different repo for zipkin, this uses https://github.com/rnburn/zipkin-cpp-opentracing.git ? |
|
I've updated this PR to cross-compile libraries and commented out gRPC since it's not used at the moment (and causes problems) |