Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker images for arm, arm64, ppc64le and s390x #186

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Aug 30, 2021

  • Adds support for building and pushing Docker images for arm64 and ppc64le
  • New builds for with edge tag for every push to master

Resolves #184

@lucacome lucacome force-pushed the multiarch-build branch 2 times, most recently from ab0c48a to a19a152 Compare August 30, 2021 19:56
ci/do_ci.sh Outdated Show resolved Hide resolved
ci/do_ci.sh Outdated Show resolved Hide resolved
@lucacome
Copy link
Member Author

lucacome commented Sep 1, 2021

Without caching from CirceCI (or a bigger machine) I think this build for multiple acrhitectures will take forever and possibly timeout.
I think I'm going to try and port just the Docker build to GitHub Actions, what do you think @miry ?

@miry
Copy link
Collaborator

miry commented Sep 1, 2021

I think I'm going to try and port just the Docker build to GitHub Actions, what do you think @miry ?

@lucacome Would be awesome.

@lucacome lucacome force-pushed the multiarch-build branch 3 times, most recently from 3fbc928 to a0731cc Compare September 1, 2021 20:34
@lucacome
Copy link
Member Author

lucacome commented Sep 1, 2021

@miry updated, but GitHub Actions are not enabled for the repo 🙂

@miry
Copy link
Collaborator

miry commented Sep 9, 2021

Let me test the github actions without push.

@miry
Copy link
Collaborator

miry commented Sep 9, 2021

@rnburn Hi.

We would like to switch from CircleCI to github actions for Release management and push docker images to DokcerHub.
There is missing permissions for me to add new Secrets to the repo: https://docs.github.com/en/actions/reference/encrypted-secrets#creating-encrypted-secrets-for-an-environment

I am kinda get the values for:

 ${{ secrets.DOCKER_USERNAME }}
 ${{ secrets.DOCKER_PASSWORD }}

but I could not create secrets in Github Repo settings.

Can you create secrets or give me for short time the permissions to the repo settings for secrets management to my account?

@rnburn
Copy link
Collaborator

rnburn commented Sep 9, 2021

@miry - I updated you to be an admin. Let me know if that works.

@lucacome
Copy link
Member Author

@miry did you get a chance to test the action? Let me know if there's something I can do to help

@lucacome lucacome changed the title Add Docker images for arm64 and ppc64le Add Docker images for arm, arm64, ppc64le and s390x Sep 14, 2021
@lucacome
Copy link
Member Author

After #190 we can build for arm, arm64, ppc64le and s390x

@miry
Copy link
Collaborator

miry commented Sep 14, 2021

@lucacome sorry for long reply. I had a busy week.

@miry
Copy link
Collaborator

miry commented Sep 14, 2021

@lucacome need to find some channel where we can communicate faster :)

I sent DM in cloud-native.slack.com

@miry
Copy link
Collaborator

miry commented Sep 14, 2021

I would like to start with small part. Lets implement part to test Docker build on PR?
https://github.com/docker/build-push-action/blob/master/docs/advanced/local-registry.md

Then next PR create a release part

Copy link
Collaborator

@miry miry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to release next version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Docker images for supported architectures
3 participants