-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundle): update label and description of bundle.json #812
feat(bundle): update label and description of bundle.json #812
Conversation
WalkthroughThe changes involve modifications to the logic of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/common/component/ConfigItem.vue (1 hunks)
- packages/plugins/materials/src/composable/useMaterial.js (2 hunks)
Additional context used
GitHub Check: push-check
packages/plugins/materials/src/composable/useMaterial.js
[failure] 367-367:
Unexpected console statement
[failure] 458-458:
'a' is assigned a value but never used. Allowed unused vars must match /^_/u
Additional comments not posted (1)
packages/common/component/ConfigItem.vue (1)
189-189
: LGTM! Improved localization supportThe change in the
propLabel
computed property enhances localization support by prioritizing the localized label text. This aligns well with the PR objective of displaying the label instead of the property in the property panel.Benefits:
- Improved user experience for localized interfaces.
- Consistent with the intended behavior described in the PR summary.
- Fallback mechanism is preserved, ensuring a value is always displayed.
* feat(bundle): 修改bundle里物料属性的label * Update useMaterial.js * feat(bundle): 修改bundle.json中物料的属性label和desc,使属性面板显示中文label * feat(bundle): 修改bundle.json中物料的属性label和desc,使属性面板显示中文label * feat(bundle): 修改bundle.json中物料的属性label和desc,使属性面板显示中文label
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
propLabel
to ensure accurate display based on available data.