Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating the login flow to save multiple practitioner details #2623

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Updating the login flow to save multiple practitioner details #2623

merged 7 commits into from
Jul 28, 2023

Conversation

dubdabasoduba
Copy link
Member

  • Update login to allow saving of multiple practitioner details.
  • Update the status code set when the FHIR conditions are closed by the events management
  • Update the login pieces to download configs every time the user is on the username/password screen

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@dubdabasoduba
- Update login to allow saving of multiple practtioner details.
892d4bb 
- Update the status code set when the FHIR conditions are closed by the events management
- Update the login pieces to download configs everytime the user is on the username/password screen
@dubdabasoduba dubdabasoduba self-assigned this Jul 26, 2023
@ndegwamartin ndegwamartin merged commit 138a40d into opensrp-0.2.5 Jul 28, 2023
@ndegwamartin ndegwamartin deleted the save_extra_details branch July 28, 2023 20:57
ndegwamartin added a commit that referenced this pull request Aug 1, 2023
@dubdabasoduba @ndegwamartin
Updating the login flow to save multiple practitioner details (#2623)
d01f73e 
* Update login to allow saving of multiple Practitioner details.
* Update the status code set when the FHIR conditions are closed by the events management
* Update the login pieces to download configs every time the user is on the username/password screen
* Update the login view model to save the practitioner details for supervisor and CHWs
* Remove the Snackbar display every time sync fails
* Bump up version name
* Refactor configs to request via Batch POST

---------

Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>
ndegwamartin added a commit that referenced this pull request Aug 2, 2023
@dubdabasoduba @ndegwamartin
Updating the login flow to save multiple practitioner details (#2623)
b8b2d69 
* Update login to allow saving of multiple Practitioner details.
* Update the status code set when the FHIR conditions are closed by the events management
* Update the login pieces to download configs every time the user is on the username/password screen
* Update the login view model to save the practitioner details for supervisor and CHWs
* Remove the Snackbar display every time sync fails
* Bump up version name
* Refactor configs to request via Batch POST

---------

Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>
AbdulWahabMemon added a commit that referenced this pull request Aug 7, 2023
@AbdulWahabMemon
Merge branch 'main' into echis-child-sm-tests
97a3e57 
* main:
  Make SideMenu items scrollable (#2645)
  Add progress indicator for report generation (#2635)
  CHT measure report result screen (#2624)
  Provide missing QuestionnaireResponse in bundle param for FhirCarePlanGenerator#conditionallyUpdateResourceStatus (#2643)
  Fix resource closure failure after server sync (#2639)
  Fix build
  add more further reading (#2637)
  Refactor questionnaire implementation (#2622)
  Fix Unit Tests + Build 💚
  Fix Unit Tests ✅
  Clean up
  Fix Unit tests ✅
  Updating the login flow to save multiple practitioner details (#2623)
  Disable Dialog Dismiss Incase of Initial Sync Errors (#2608)
  Add the new ecbis production flavor
  Performance tests for loading register data (#2592)
  Fix back navigation for date selection page (#2628)
  Create github release file (#2611)
  Add form authoring consideration documentation (#2618)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
@dubdabasoduba @ndegwamartin
Updating the login flow to save multiple practitioner details (#2623)
602bec4 
* Update login to allow saving of multiple Practitioner details.
* Update the status code set when the FHIR conditions are closed by the events management
* Update the login pieces to download configs every time the user is on the username/password screen
* Update the login view model to save the practitioner details for supervisor and CHWs
* Remove the Snackbar display every time sync fails
* Bump up version name
* Refactor configs to request via Batch POST

---------

Co-authored-by: Martin Ndegwa <mndegwa@ona.io>
Co-authored-by: Martin Ndegwa <ndegwamartin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin approved these changes

Assignees

@dubdabasoduba dubdabasoduba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dubdabasoduba @ndegwamartin