Performance tests for loading register data #2592

ekigamba · 2023-07-17T10:15:27Z

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2066

Engineer Checklist

I have written Unit tests for any new feature(s) and edge cases for bug fixes
I have added any strings visible on UI components to the strings.xml file
I have updated the CHANGELOG.md file for any notable changes to the codebase
I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

I have verified Unit tests have been written for any new feature(s) and edge cases
I have verified any strings visible on UI components are in the strings.xml file
I have verifed the CHANGELOG.md file has any notable changes to the codebase
I have verified the solution has been implemented in a configurable and generic way for reuseable components
I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

…e-tests-load-data

codecov · 2023-07-17T11:21:57Z

Codecov Report

Merging #2592 (96646bb) into main (d84c2c8) will decrease coverage by 0.1%.
Report is 33 commits behind head on main.
The diff coverage is 67.6%.

@@            Coverage Diff            @@
##              main   #2592     +/-   ##
=========================================
- Coverage     65.4%   65.4%   -0.1%     
- Complexity    1101    1148     +47     
=========================================
  Files          213     216      +3     
  Lines         9385    9743    +358     
  Branches      1866    1932     +66     
=========================================
+ Hits          6140    6372    +232     
- Misses        2047    2154    +107     
- Partials      1198    1217     +19

Flag	Coverage Δ
engine	`73.1% <70.4%> (+<0.1%)`	⬆️
geowidget	`64.3% <37.5%> (+1.0%)`	⬆️
quest	`60.3% <65.7%> (-0.2%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt	`25.0% <ø> (ø)`
...ngine/configuration/event/EventTriggerCondition.kt	`50.0% <0.0%> (ø)`
...ircore/engine/configuration/event/EventWorkflow.kt	`33.3% <0.0%> (ø)`
...ngine/configuration/view/PersonalDataProperties.kt	`0.0% <0.0%> (ø)`
...hircore/engine/configuration/view/RowProperties.kt	`0.0% <ø> (ø)`
...ine/configuration/view/ViewPropertiesSerializer.kt	`23.8% <0.0%> (ø)`
...data/remote/fhir/resource/FhirResourceConverter.kt	`100.0% <ø> (ø)`
...e/data/remote/fhir/resource/FhirResourceService.kt	`0.0% <0.0%> (ø)`
...hircore/engine/domain/model/FhirResourceConfigs.kt	`44.4% <0.0%> (ø)`
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt	`33.3% <0.0%> (ø)`
... and 135 more

... and 21 files with indirect coverage changes

...androidTest/java/org/smartregister/fhircore/performance/HouseholdRegisterPerformanceTests.kt

ekigamba · 2023-07-26T06:54:06Z

android/quest/build.gradle.kts

@@ -361,8 +370,79 @@ dependencies {
  androidTestImplementation(libs.ui.test.junit4)
  androidTestImplementation(libs.hilt.android.testing)
  androidTestImplementation(libs.mockk.android)
+  androidTestImplementation("androidx.benchmark:benchmark-junit4:1.1.1")


Move this to libs.versions.toml

does this still need to be moved?

android/quest/build.gradle.kts

...ne/src/main/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepository.kt

pld · 2023-07-26T15:40:23Z

.github/workflows/performance-tests.yml

+    runs-on: macos-latest
+    strategy:
+      matrix:
+        api-level: [28]


ah I see now, it'd be nice to get this down to 26 or whatever level we say we're supporting, but feels like better for follow-up work not this pr

android/jacoco.gradle.kts

android/quest/build.gradle.kts

...androidTest/java/org/smartregister/fhircore/performance/HouseholdRegisterPerformanceTests.kt

- Run instrumentation tests and pull coverage file into quest directory. Include the coverage file in Jacoco task

- Fixes the class bytecode being different for the instrumentation test and unit tests

Rkareko · 2023-08-02T07:43:04Z

docs/engineering/android-app/introduction/readme.mdx

-1. Unit tests
-2. UI and integration tests
+The OpenSRP Android app includes automated style, coverage, unit, user inteface / integartion, and performance testing. All tests are run through github actions on pull request and must be passed for a pull request to be merged without an admin override.
+


change must be passed to must pass

* main: Make SideMenu items scrollable (#2645) Add progress indicator for report generation (#2635) CHT measure report result screen (#2624) Provide missing QuestionnaireResponse in bundle param for FhirCarePlanGenerator#conditionallyUpdateResourceStatus (#2643) Fix resource closure failure after server sync (#2639) Fix build add more further reading (#2637) Refactor questionnaire implementation (#2622) Fix Unit Tests + Build 💚 Fix Unit Tests ✅ Clean up Fix Unit tests ✅ Updating the login flow to save multiple practitioner details (#2623) Disable Dialog Dismiss Incase of Initial Sync Errors (#2608) Add the new ecbis production flavor Performance tests for loading register data (#2592) Fix back navigation for date selection page (#2628) Create github release file (#2611) Add form authoring consideration documentation (#2618)

* Draft: Commit * Daft commit: Run tests i CI * code cleanup * Remove other CI tasks * Fix performance tests assertion * Fix performance tests assertion * Fix performance tests assertion * Allow SSH debugging * Rerun SSH debugging * Breakdown performance testing steps * Breakdown performance testing steps * Breakdown performance testing steps * Breakdown performance testing steps * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Fix apk install sequence * List files in the sdcard/Download folder * Enable JSON output for performance test results * Enable JSON output for performance test results * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Fix instrumentation running * Update performance tests github workflow - Revert github workflow for CI - Revert household register page size to 20 * Run quest instrumentation tests before fhircoreJacocoReport task * Clean up gradle files & performance results evaluation task * Update the expected performance numbers for HouseholdRegister tests * Refactor evaluatePerformanceBenchmarkResults * Add compressed and zipped resources.db for performance testing * Update performance-tests workflow to extract resources.db * Ignore the resources.db in quest/androidTest * Reformat and clean code * Update quest tests to skip performance tests - Run instrumentation tests and pull coverage file into quest directory. Include the coverage file in Jacoco task * Run instrumentation tests for opensrp variant instead of ecbis - Fixes the class bytecode being different for the instrumentation test and unit tests * Update android/jacoco.gradle.kts * Update android/quest/build.gradle.kts * Update performance-tests.yml * fix multiline comments * expanding testing section * add note on coverage and performance * add change note --------- Co-authored-by: Ephraim Kigamba <n.kigamba@students.ku.ac.ke> Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>

Kigamba and others added 3 commits July 13, 2023 16:21

Draft: Commit

cfaf286

Daft commit: Run tests i CI

81a5c9a

Merge remote-tracking branch 'origin/main' into issue/2066-performanc…

fef6ac9

…e-tests-load-data

ekigamba force-pushed the issue/2066-performance-tests-load-data branch from 95b0d34 to fef6ac9 Compare July 17, 2023 10:39

ekigamba force-pushed the issue/2066-performance-tests-load-data branch 3 times, most recently from 299fece to dd94e2a Compare July 17, 2023 12:38

ekigamba changed the title ~~Draft: Commit~~ Performance tests for loading register data Jul 17, 2023

ekigamba force-pushed the issue/2066-performance-tests-load-data branch 3 times, most recently from 5ae5279 to 2158133 Compare July 17, 2023 13:04

pld reviewed Jul 17, 2023

View reviewed changes

...androidTest/java/org/smartregister/fhircore/performance/HouseholdRegisterPerformanceTests.kt Show resolved Hide resolved

code cleanup

1a79ea0

ekigamba force-pushed the issue/2066-performance-tests-load-data branch from 2158133 to 1a79ea0 Compare July 18, 2023 13:48

ekigamba and others added 15 commits July 18, 2023 17:42

Remove other CI tasks

aa497fe

Fix performance tests assertion

177ae85

Merge branch 'main' into issue/2066-performance-tests-load-data

b3fda7d

Fix performance tests assertion

b70ff1f

Fix performance tests assertion

60cce55

Allow SSH debugging

852e4fa

Rerun SSH debugging

c4e877a

Breakdown performance testing steps

0d66ab1

Breakdown performance testing steps

ab44594

Breakdown performance testing steps

56438a4

Breakdown performance testing steps

2c9fad8

Fix instrumentation running

742a5ea

Fix instrumentation running

a8cb9bd

Fix instrumentation running

f1e434a

Fix instrumentation running

97a567c

ekigamba commented Jul 26, 2023

View reviewed changes

android/quest/build.gradle.kts Show resolved Hide resolved

ekigamba commented Jul 26, 2023

View reviewed changes

...ne/src/main/java/org/smartregister/fhircore/engine/data/local/register/RegisterRepository.kt Outdated Show resolved Hide resolved

Reformat and clean code

d47d5d8

pld previously approved these changes Jul 26, 2023

View reviewed changes

Update quest tests to skip performance tests

6e08720

- Run instrumentation tests and pull coverage file into quest directory. Include the coverage file in Jacoco task

ekigamba dismissed pld’s stale review via 6e08720 July 30, 2023 20:47

Run instrumentation tests for opensrp variant instead of ecbis

a37158a

- Fixes the class bytecode being different for the instrumentation test and unit tests

ekigamba force-pushed the issue/2066-performance-tests-load-data branch from 3d94700 to a37158a Compare July 31, 2023 21:17

ekigamba and others added 2 commits August 1, 2023 02:06

Merge branch 'main' into issue/2066-performance-tests-load-data

11aa499

Merge branch 'main' into issue/2066-performance-tests-load-data

51d9ecf

ekigamba marked this pull request as ready for review August 1, 2023 07:42

ekigamba requested a review from pld August 1, 2023 07:42

Update android/jacoco.gradle.kts

de5c52a

ekigamba requested a review from Rkareko August 1, 2023 12:52

pld added 2 commits August 1, 2023 08:52

Update android/quest/build.gradle.kts

73dde8a

Update performance-tests.yml

7f54d93

pld previously approved these changes Aug 1, 2023

View reviewed changes

pld added 2 commits August 1, 2023 09:21

fix multiline comments

edbd449

expanding testing section

a652b0a

pld dismissed their stale review via a652b0a August 1, 2023 13:59

pld added 2 commits August 1, 2023 10:36

add note on coverage and performance

207dd02

add change note

96646bb

pld approved these changes Aug 1, 2023

View reviewed changes

pld merged commit 5e54710 into main Aug 1, 2023

pld deleted the issue/2066-performance-tests-load-data branch August 1, 2023 16:42

Rkareko reviewed Aug 2, 2023

View reviewed changes

ekigamba mentioned this pull request Aug 2, 2023

[Tech Debt] Tech debt from PR 2592 #2633

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Performance tests for loading register data #2592

Performance tests for loading register data #2592

ekigamba commented Jul 17, 2023 •

edited

Loading

codecov bot commented Jul 17, 2023 •

edited

Loading

ekigamba Jul 26, 2023

pld Aug 1, 2023

ekigamba Aug 2, 2023

pld Jul 26, 2023

ekigamba Aug 2, 2023

Rkareko Aug 2, 2023

Performance tests for loading register data #2592

Performance tests for loading register data #2592

Conversation

ekigamba commented Jul 17, 2023 • edited Loading

codecov bot commented Jul 17, 2023 • edited Loading

Codecov Report

ekigamba Jul 26, 2023

Choose a reason for hiding this comment

pld Aug 1, 2023

Choose a reason for hiding this comment

ekigamba Aug 2, 2023

Choose a reason for hiding this comment

pld Jul 26, 2023

Choose a reason for hiding this comment

ekigamba Aug 2, 2023

Choose a reason for hiding this comment

Rkareko Aug 2, 2023

Choose a reason for hiding this comment

ekigamba commented Jul 17, 2023 •

edited

Loading

codecov bot commented Jul 17, 2023 •

edited

Loading