Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change p2p fetch records query to fix slowness (#2554) #2562

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

ekigamba
Copy link
Contributor

@ekigamba ekigamba commented Jul 10, 2023

Fixes #2536

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Fixes #2536

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #2562 (d23ef44) into main (d84c2c8) will decrease coverage by 0.1%.
The diff coverage is 60.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2562     +/-   ##
=========================================
- Coverage     65.4%   65.4%   -0.1%     
- Complexity    1101    1102      +1     
=========================================
  Files          213     213             
  Lines         9385    9386      +1     
  Branches      1866    1865      -1     
=========================================
- Hits          6140    6139      -1     
- Misses        2047    2050      +3     
+ Partials      1198    1197      -1     
Flag Coverage Δ
engine 73.0% <57.1%> (-0.1%) ⬇️
geowidget 63.2% <ø> (ø)
quest 60.4% <62.5%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ircore/engine/ui/components/register/LoaderView.kt 66.6% <40.0%> (-2.8%) ⬇️
...ter/fhircore/quest/ui/register/RegisterFragment.kt 39.8% <50.0%> (ø)
...register/fhircore/quest/ui/main/AppMainActivity.kt 59.2% <66.6%> (-1.0%) ⬇️
...ster/fhircore/engine/p2p/dao/BaseP2PTransferDao.kt 89.7% <100.0%> (+0.2%) ⬆️

@pld pld self-assigned this Jul 10, 2023
@pld pld merged commit 54d3e95 into main Jul 10, 2023
@pld pld deleted the issue/main/2536-p2p-slow branch July 10, 2023 20:18
@ekigamba
Copy link
Contributor Author

@pld Thanks 🙏

qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Change p2p fetch records query to fix slowness (#2554)

Fixes #2536

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>

* update test

---------

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: pld <peter@ona.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P2P] Possible p2p sync slow regression
2 participants