Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update p2p query to match new indexes #2554

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Update p2p query to match new indexes #2554

merged 2 commits into from
Jul 7, 2023

Conversation

ekigamba
Copy link
Contributor

@ekigamba ekigamba commented Jul 7, 2023

Change p2p fetch records query to fix slowness

Fixes #2536

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@ekigamba ekigamba force-pushed the issue/2536-p2p-slow branch from 1de97b1 to 4d2deaa Compare July 7, 2023 16:32
@ekigamba ekigamba marked this pull request as ready for review July 7, 2023 16:32
@ndegwamartin ndegwamartin merged commit 4b4bef0 into opensrp-0.2.4 Jul 7, 2023
@ndegwamartin ndegwamartin deleted the issue/2536-p2p-slow branch July 7, 2023 18:12
ekigamba added a commit that referenced this pull request Jul 10, 2023
@ekigamba @dubdabasoduba
Change p2p fetch records query to fix slowness (#2554)
309f76b 
Fixes #2536

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
pld added a commit that referenced this pull request Jul 10, 2023
@ekigamba @dubdabasoduba @pld
Change p2p fetch records query to fix slowness (#2554) (#2562)
54d3e95 
* Change p2p fetch records query to fix slowness (#2554)

Fixes #2536

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>

* update test

---------

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: pld <peter@ona.io>
qiarie pushed a commit that referenced this pull request Jan 15, 2025
@ekigamba @dubdabasoduba @pld
Change p2p fetch records query to fix slowness (#2554) (#2562)
cedcb59 
* Change p2p fetch records query to fix slowness (#2554)

Fixes #2536

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>

* update test

---------

Co-authored-by: Benjamin Mwalimu <dubdabasoduba@gmail.com>
Co-authored-by: pld <peter@ona.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndegwamartin ndegwamartin ndegwamartin approved these changes

Assignees

@ndegwamartin ndegwamartin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekigamba @ndegwamartin @dubdabasoduba