-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kola-denylist: use string instead of list for tracker #599
Conversation
I strongly believe that I tested the use of a list in the denylist as part of openshift#595, but evidence says otherwise.
|
You mean you can't confirm...or deny it. |
If this fails let's merge anyways but I want to see where we get from this run - at least kata should be in now. |
This is a comedy of errors |
aos repo just got it, not sure if there's another process needed to sync |
/override ci/prow/build-test-qemu |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Perhaps the sync from internal to the CI cluster is on a timer or what not |
If you somehow used cosa before coreos/coreos-assembler#2296 when testing #595, that could explain why it worked. In Python, we just stringified it when printing. But we lost that when moving to stronger typing in golang. Not a bad idea to officially support it though, even if just as a different e.g. |
I strongly believe that I tested the use of a list in the denylist as
part of #595, but evidence says otherwise.