kola: Move kola-denylist.yaml related sugar from cmd-kola to kola #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustymabe
reviewed
Jul 15, 2021
dustymabe
reviewed
Jul 15, 2021
|
For your first commit message I'd break it up slightly: We try to have a single title line, then a blank line, then a description. |
Thanks for pointing that out! I'll try to follow that format from now on. |
a660ddc to
99e00be
Compare
dustymabe
approved these changes
Jul 19, 2021
99e00be to
2f1a501
Compare
jlebon
approved these changes
Jul 19, 2021
Added functionality to parse deny listed tests from a `kola-denylist.yaml` file if found. This moves the functionality from cmd-kola (python) into kola proper (golang).
…in kola-denylist.yaml are skipped
2f1a501 to
234b9fc
Compare
|
/lgtm |
|
/override ci/prow/sanity |
|
@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/sanity In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
overriding the shellcheck CI issue that's been plaguing us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before introducing more functionality to deny listed tests, we want to have the deny list logic contained in a single location (kola).