Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if no login idps are present #11235

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Warn if no login idps are present #11235

merged 1 commit into from
Oct 10, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Oct 5, 2016

Will show up in diagnostics if someone turns off login for all their idps

@enj
Copy link
Contributor

enj commented Oct 5, 2016

LGTM

@enj enj added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2016
@liggitt
Copy link
Contributor Author

liggitt commented Oct 5, 2016

[merge]

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@liggitt
Copy link
Contributor Author

liggitt commented Oct 6, 2016

flaked on #10487 [test]

@liggitt
Copy link
Contributor Author

liggitt commented Oct 7, 2016

flaked on #11240 [test]

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 66ef1db

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9752/)

@liggitt
Copy link
Contributor Author

liggitt commented Oct 9, 2016

yum and cli-with-token2 exec flake [merge]

@liggitt
Copy link
Contributor Author

liggitt commented Oct 10, 2016

#11240 flake
[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 66ef1db

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 10, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9830/) (Image: devenv-rhel7_5160)

@openshift-bot openshift-bot merged commit 88a2e30 into openshift:master Oct 10, 2016
@liggitt liggitt deleted the warn-no-idps branch October 12, 2016 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants