Merge pull request #11235 from liggitt/warn-no-idps

Merged by openshift-bot
openshift · Oct 10, 2016 · 88a2e30 · 88a2e30
2 parents 606716e + 66ef1db
commit 88a2e30
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/cmd/server/api/validation/oauth.go b/pkg/cmd/server/api/validation/oauth.go
@@ -86,6 +86,9 @@ func ValidateOAuthConfig(config *api.OAuthConfig, fldPath *field.Path) Validatio
 		}
 	}
 
+	if len(redirectingIdentityProviders) == 0 {
+		validationResults.AddWarnings(field.Invalid(fldPath.Child("identityProviders"), "login", "no identity providers are configured to handle logins"))
+	}
 	if len(challengeRedirectingIdentityProviders) > 1 {
 		validationResults.AddErrors(field.Invalid(fldPath.Child("identityProviders"), "challenge", fmt.Sprintf("only one identity provider can redirect clients requesting an authentication challenge, found: %v", strings.Join(challengeRedirectingIdentityProviders, ", "))))
 	}