Adding function to verify Backup / Restore data #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
deepakraj1997
commented
Apr 6, 2022
•
- Fix Bug: OADP tests/e2e backup and restore tests NEED to validate data matches before and after restore. #619
- Unable to verify Parks App data backup / restore due to multiple deployment of the same application on restore which makes the test cases unable to verify parks app.
|
Skipping CI for Draft Pull Request. |
|
@deepakraj1997 nice start dude! |
|
/retest |
weshayutin
reviewed
Apr 20, 2022
| @@ -47,6 +47,7 @@ var _ = Describe("AWS backup restore tests", func() { | |||
|
|
|||
| parksAppReady := VerificationFunction(func(ocClient client.Client, namespace string) error { | |||
| Eventually(IsDCReady(ocClient, "parks-app", "restify"), timeoutMultiplier*time.Minute*10, time.Second*10).Should(BeTrue()) | |||
| // err := VerifyBackUpRestoreData(artifact_dir, namespace, "restify", "parks-app") // TODO: VERIFY PARKS APP DATA | |||
There was a problem hiding this comment.
thanks... looking at the parks app.. the last commit was in 2016. I'm a little suspicious of this app. https://github.com/ryanj/restify-mongodb-parks
There was a problem hiding this comment.
I had added the issue in the description although we could verify the data if we add a wait function.
|
/retest |
1 similar comment
|
/retest |
|
+1 to making this part of the validation VERY resiliant |
kaovilai
requested changes
Apr 22, 2022
tests/e2e/lib/apps.go
Outdated
| @@ -197,3 +203,54 @@ func RunMustGather(oc_cli string, artifact_dir string) error { | |||
| _, err := cmd.Output() | |||
| return err | |||
| } | |||
|
|
|||
| func VerifyBackUpRestoreData(artifact_dir string, namespace string, routeName string, app string) error { | |||
There was a problem hiding this comment.
Suggested change
| func VerifyBackUpRestoreData(artifact_dir string, namespace string, routeName string, app string) error { | |
| func VerifyBackupRestoreData(artifact_dir string, namespace string, routeName string, app string) error { |
1 task
weshayutin
added a commit
to weshayutin/oadp-operator
that referenced
this pull request
Apr 28, 2022
* created a version of todolist for mongo * ensure the manifest builds and triggers just like the parks-app did * adv is that the same app api can be used to add data to the db and check after restore. Related PR openshift#624 Resolves: openshift#646
|
/retest |
kaovilai
approved these changes
Apr 29, 2022
|
@deepakraj1997: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
weshayutin
added a commit
to weshayutin/oadp-operator
that referenced
this pull request
May 3, 2022
* created a version of todolist for mongo * ensure the manifest builds and triggers just like the parks-app did * adv is that the same app api can be used to add data to the db and check after restore. Related PR openshift#624 Resolves: openshift#646
weshayutin
added a commit
to weshayutin/oadp-operator
that referenced
this pull request
May 3, 2022
* created a version of todolist for mongo * ensure the manifest builds and triggers just like the parks-app did * adv is that the same app api can be used to add data to the db and check after restore. Related PR openshift#624 Resolves: openshift#646
kaovilai
pushed a commit
that referenced
this pull request
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.