Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: OADP tests/e2e backup and restore tests NEED to validate data matches before and after restore. #619

Closed
1 task done
weshayutin opened this issue Mar 31, 2022 · 0 comments · Fixed by #624
Closed
1 task done
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@weshayutin
Copy link
Contributor

Contact Details

whayutin@redhat.com

Describe bug

Looking at the tests/e2e code:
https://github.com/openshift/oadp-operator/blob/master/tests/e2e/backup_restore_suite_test.go#L136-L154

Once can see that the tests are not taking the raw db data prior to the backup and testing that the restore infact restored the data in the db. The test is only confirming that the application comes back up in a working state.

To fix this:

  1. Just before the backup is executed, dump the database table to file, take a md5sum check of the file
  2. backup, delete, restore app
  3. After the app is restored, again dump the database table to file, compare the restored md5sum to the md5sum prior to the backup.
  4. The two md5sum entries should match.

What happened?

There is no raw data tests being executed

OADP Version

1.0.1 (Stable)

OpenShift Version

4.10

Velero pod logs

No response

Restic pod logs

No response

Operator pod logs

No response

New issue

  • This issue is new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants