Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed git tags, commit ID and tree status in srpm #305

Merged
merged 1 commit into from
Dec 10, 2021
Merged

Embed git tags, commit ID and tree status in srpm #305

merged 1 commit into from
Dec 10, 2021

Conversation

mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Sep 24, 2021 •
edited
Loading

Embedding those details, and then injecting then back during
srpm building (instead of looking for the git details which
doesn't exist anymore for an srpm build -it's a tarball-)
allows for microshift being properly compiled with those
details in the binary.

Closes-Issue: #476

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

@openshift-ci openshift-ci bot requested review from oglok and sallyom September 24, 2021 09:50
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

Hi @mangelajo. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2021
@rootfs
Copy link
Member

rootfs commented Sep 24, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@rootfs
Copy link
Member

rootfs commented Sep 24, 2021

/assign @copejon

@mangelajo mangelajo force-pushed the embed-srpm-git-details branch from 86061af to f6544e6 Compare October 29, 2021 09:30
@netlify
Copy link

netlify bot commented Oct 29, 2021 •
edited
Loading

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: a227f56

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/617bbf9f91f49c000721022a

@mangelajo mangelajo force-pushed the embed-srpm-git-details branch from f6544e6 to a227f56 Compare October 29, 2021 09:32
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2021

@mangelajo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-storage a227f56 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-api-machinery a227f56 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mangelajo mangelajo mentioned this pull request Dec 10, 2021
Closed
@mangelajo
Copy link
Contributor Author

@fzdarsky ^

@mangelajo mangelajo linked an issue Dec 10, 2021 that may be closed by this pull request
[BUG] .rpm-installed MicroShift shows "unknown" version #476
Closed
@mangelajo
Embed git tags, commit ID and tree status in srpm
85c4540 
Embedding those details, and then injecting then back during
srpm building (instead of looking for the git details which
doesn't exist anymore for an srpm build -it's a tarball-)
allows for microshift being properly compiled with those
details in the binary.

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
@mangelajo mangelajo force-pushed the embed-srpm-git-details branch from a227f56 to 85c4540 Compare December 10, 2021 11:42
@mangelajo
Copy link
Contributor Author

Re-tested manually the srpm / rpm building, this is good to go

@fzdarsky
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky, rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fzdarsky fzdarsky merged commit 18aff6b into openshift:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oglok oglok Awaiting requested review from oglok

@sallyom sallyom Awaiting requested review from sallyom

Assignees

@copejon copejon

@fzdarsky fzdarsky

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] .rpm-installed MicroShift shows "unknown" version
4 participants
@mangelajo @rootfs @fzdarsky @copejon