Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] .rpm-installed MicroShift shows "unknown" version #476

Closed
fzdarsky opened this issue Dec 2, 2021 · 2 comments · Fixed by #305
Closed

[BUG] .rpm-installed MicroShift shows "unknown" version #476

fzdarsky opened this issue Dec 2, 2021 · 2 comments · Fixed by #305
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@fzdarsky
Copy link
Contributor

fzdarsky commented Dec 2, 2021

What happened:

Running microshift version on MicroShift installed via latest .rpm from COPR shows an "unknown" version:

$ microshift version
MicroShift Version: 4.8.0-0.microshift-unknown
Base OKD Version: 4.8.0-0.okd-2021-10-10-030117

What you expected to happen:

It should show the version correctly as:

$ microshift version
MicroShift Version: 4.8.0-0.microshift-2021-11-19-115908 
Base OKD Version: 4.8.0-0.okd-2021-10-10-030117

How to reproduce it (as minimally and precisely as possible):

  1. Install microshift.rpm according to "Getting Started" documentation:
...
sudo dnf copr enable -y @redhat-et/microshift
sudo dnf install -y microshift
  1. Run microshift version

Anything else we need to know?:

Environment:

  • Microshift version (use microshift version): see above
  • Hardware configuration: vagrant + VirtualBox
  • OS (e.g: cat /etc/os-release): Fedora 34 cloud image
  • Kernel (e.g. uname -a): Linux fedora 5.11.12-300.fc34.x86_64 Init #1 SMP Wed Apr 7 16:31:13 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
  • Others:

Relevant Logs

@fzdarsky fzdarsky added the kind/bug Categorizes issue or PR as related to a bug. label Dec 2, 2021
@fzdarsky fzdarsky changed the title [BUG] <title> [BUG] .rpm-installed MicroShift shows "unknown" version Dec 2, 2021
@fzdarsky
Copy link
Contributor Author

fzdarsky commented Dec 2, 2021

Additional data from @mangelajo from the build logs:

+ make _build_local GOOS=linux GOARCH=amd64
/usr/bin/bash: line 1: git: command not found
/usr/bin/bash: line 1: git: command not found
mkdir -p '_output/bin/linux_amd64'
go build -mod=vendor -tags 'include_gcs include_oss containers_image_openpgp gssapi providerless netgo osusergo' -ldflags "-X k8s.io/component-base/version.gitMajor=1 -X k8s.io/component-base/version.gitMajor=1 -X k8s.io/component-base/version.gitMinor=21 -X k8s.io/component-base/version.gitVersion=v1.21.0 -X k8s.io/component-base/version.gitCommit=c3b9e07a -X k8s.io/component-base/version.gitTreeState=clean -X k8s.io/component-base/version.buildDate=2021-11-19T12:22:36Z -X k8s.io/client-go/pkg/version.gitMajor=1 -X k8s.io/client-go/pkg/version.gitMinor=21 -X k8s.io/client-go/pkg/version.gitVersion=v1.21.1 -X k8s.io/client-go/pkg/version.gitCommit=b09a9ce3 -X k8s.io/client-go/pkg/version.gitTreeState=clean -X k8s.io/client-go/pkg/version.buildDate=2021-11-19T12:22:36Z -X github.com/openshift/microshift/pkg/version.versionFromGit=4.8.0-0.microshift-unknown -X github.com/openshift/microshift/pkg/version.commitFromGit= -X github.com/openshift/microshift/pkg/version.gitTreeState=clean -X github.com/openshift/microshift/pkg/version.buildDate=2021-11-19T12:22:36Z -s -w" -o '_output/bin/linux_amd64/microshift' github.com/openshift/microshift/cmd/microshift
+ cp ./_output/bin/linux_amd64/microshift ./_output/microshift

@mangelajo
Copy link
Contributor

Help me merge this:

#305

It was supposed to handle it, I thought it was long merged :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants