-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2003027: Rebase 1.20.10 #935
Bug 2003027: Rebase 1.20.10 #935
Conversation
… create ingress (kubernetes#101428) * Fix validation in kubectl create ingress Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com> * Fix validation in kubectl create ingress Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
…pick-of-#100013-upstream-release-1.20 [1.20] Add duration encoder to structured logger
…-of-#100103-upstream-release-1.20 Automated cherry pick of kubernetes#100103: Updating EndpointSlice controllers to avoid duplicate
…pick-of-#99550-upstream-release-1.20 Automated cherry pick of kubernetes#99550: fix smb mount issue on Windows
…-pick-of-#101235-upstream-release-1.20 Automated cherry pick of kubernetes#101235: fix: azure file namespace issue in csi translation
…pick-of-#101005-upstream-release-1.20 Automated cherry pick of kubernetes#101005: Set namespace when using kubectl create service
…-pick-of-#101398-upstream-release-1.20 Automated cherry pick of kubernetes#101398: fix: set "host is down" as corrupted mount
…-pick-of-#100731-upstream-release-1.20 Automated cherry pick of kubernetes#100731: Normalize share name to not include capital letters
…y-pick-of-#100944-upstream-release-1.20 Automated cherry pick of kubernetes#100944: Ensure service deleted when the Azure resource group has been deleted
…k-of-#101752-upstream-release-1.20 Cherry pick of kubernetes#101752: fix: not tagging static public IP
…rry-pick-of-#99839-upstream-release-1.20 Automated cherry pick of kubernetes#99839: Cleanup portforward streams after their usage
[1.20][go1.15] Update to go1.15.12
/override ci/prow/verify-commits |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify-commits In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manually adding valid-bug label, based on discussion in control plane arch call. |
/retest |
@soltysh: This pull request references Bugzilla bug 2003027, which is invalid:
Comment Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test e2e-aws-jenkins |
1 similar comment
/test e2e-aws-jenkins |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@sdodson: This pull request references Bugzilla bug 2003027, which is invalid:
Comment Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sdodson the BZ will never be in the correct state, we've agreed during control plane arch call from Sep 7th, that for k8s updates we'll be manually setting that label |
@soltysh why would the bug never become valid? We should at the very least make sure that we merge these bumps in descending order from 4.8 toward 4.6. I don't see why QE couldn't verify these bugs. |
@sdodson Ok I'm trying to understand how to proceed here - should we approve #888, remove the manual bugzilla/valid-bug then make this bz depend on https://bugzilla.redhat.com/show_bug.cgi?id=1994457 so we can land this when that 4.8 bump is verified? |
Based on discussion I'm removing valid-label from this PR, until we merge #888. |
[patch-manager] Approving for cherry-pick with a score of 1.00 - based on discussion yesterday we wanted to wait for #888 to land, but not necessarily block on verification of that since the fixes per-branch are not necessarily the same |
@soltysh: All pull requests linked via external trackers have merged: Bugzilla bug 2003027 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Alternative approach to #765 and #772 following the full procedure from https://github.com/openshift/kubernetes/blob/master/REBASE.openshift.md
Tracking sheet https://docs.google.com/spreadsheets/d/10KYptJkDB1z8_RYCQVBYDjdTlRfyoXILMa0Fg8tnNlY/edit#gid=1237742563
/assign @sttts @mfojtik @damemi
/cc @DhritiShikhar