Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Logging migration: modify dockershim and network part logs of kubelet. #98939

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Structured Logging migration: modify dockershim and network part logs of kubelet. #98939

merged 1 commit into from
Mar 3, 2021

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 10, 2021 •
edited
Loading

… of kubelet.

Signed-off-by: JunYang yang.jun22@zte.com.cn

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Structured Logging migration: modify dockershim and network part logs of kubelet.
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.
Does this PR introduce a user-facing change?:

Migrate `pkg/kubelet/(dockershim, network)` to structured logging
ACTION REQUIRED: Exit code changed from 255 to 1

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 10, 2021
@k8s-ci-robot
Copy link
Contributor

@yangjunmyfm192085: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @yangjunmyfm192085. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 10, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2021
adisky
adisky reviewed Feb 10, 2021
View reviewed changes
pkg/kubelet/dockershim/docker_container.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/docker_container.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/docker_image_windows.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/docker_legacy_service.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/docker_sandbox.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/docker_sandbox.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/docker_streaming_others.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
adisky
adisky reviewed Feb 10, 2021
View reviewed changes
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/cni/cni.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/hairpin/hairpin.go Outdated Show resolved Hide resolved
pkg/kubelet/dockershim/network/hostport/hostport_manager.go Outdated Show resolved Hide resolved
@yangjunmyfm192085 yangjunmyfm192085 force-pushed the run-test16 branch 8 times, most recently from 6c4dc9e to 17fd589 Compare February 10, 2021 13:35
@serathius
Copy link
Contributor

serathius commented Feb 14, 2021 •
edited
Loading

/lgtm
Please shorten release notes and include exit code change

Migrate `pkg/kubelet/(dockershim, network)` to structured logging
ACTION REQUIRED: Exit code changed from 255 to 1

/hold
/cc @ehashman

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 14, 2021
@yangjunmyfm192085
Copy link
Contributor Author

/lgtm
Please shorten release notes and include exit code change

Migrate `pkg/kubelet/(dockershim, network)` to structured logging
ACTION REQUIRED: Exit code changed from 255 to 1

/hold
/cc @ehashman

Thanks,I have modified it.

@serathius
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2021
@bowei
Copy link
Member

bowei commented Feb 18, 2021

/assign

@bowei
Copy link
Member

bowei commented Feb 20, 2021

/lgtm
/approve

@kendallroden kendallroden mentioned this pull request Feb 24, 2021
Open
39 tasks
@mrunalp
Copy link
Contributor

mrunalp commented Mar 2, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, mrunalp, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-unit

1 similar comment
@yangjunmyfm192085
Copy link
Contributor Author

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot merged commit a6a66c3 into kubernetes:master Mar 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 3, 2021
@ehashman ehashman mentioned this pull request Mar 4, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 5, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 23, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 25, 2021
Closed
9 tasks
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 1, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Jul 8, 2021
Closed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 7, 2021
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisky adisky adisky left review comments

@serathius serathius serathius requested changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@ehashman ehashman Awaiting requested review from ehashman

Assignees

@bowei bowei

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
8 participants
@yangjunmyfm192085 @k8s-ci-robot @kikisdeliveryservice @serathius @ehashman @bowei @mrunalp @adisky