Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Remove sinkbinding tests for beta1 patch #1230

Conversation

matzew
Copy link
Member

@matzew matzew commented Apr 28, 2021

Now v1beta1 are going to be removed in these upstream PRs, eventually

  • 5319

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
…ve#5319

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the fix_sinkbinding_tests_v1alpha2_v1beta1_patch branch from 2251a94 to 1636a83 Compare April 29, 2021 18:40
@matzew matzew changed the title Remove sinkbinding tests patch Remove sinkbinding tests for beta1 patch Apr 29, 2021
@matzew
Copy link
Member Author

matzew commented Apr 29, 2021

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
@lionelvillard
Copy link

/lgtm

@openshift-ci-robot
Copy link

@lionelvillard: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lberk
Copy link
Member

lberk commented Apr 29, 2021

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1cee62e into openshift:main Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants