Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sources v1beta1 #5319

Merged

Conversation

lionelvillard
Copy link
Member

/hold Depends on #5318

Proposed Changes

  • Remove all core source v1beta1 APIs

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

:wastebasket  Remove APIServerSource, ContainerSource, PingSource and SinkBinding v1beta1 APIs

Docs

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 27, 2021
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test-and-release Test infrastructure, tests or release labels Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #5319 (ce24412) into main (c2d6649) will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5319      +/-   ##
==========================================
- Coverage   82.95%   82.36%   -0.60%     
==========================================
  Files         211      189      -22     
  Lines        6291     5902     -389     
==========================================
- Hits         5219     4861     -358     
+ Misses        742      720      -22     
+ Partials      330      321       -9     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2d6649...ce24412. Read the comment docs.

matzew added a commit to matzew/eventing that referenced this pull request Apr 28, 2021
…ve#5319

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@lionelvillard lionelvillard mentioned this pull request Apr 28, 2021
5 tasks
@lionelvillard lionelvillard force-pushed the remove-sources-v1beta1 branch from 5a68bdd to ce24412 Compare April 29, 2021 14:36
@lionelvillard
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2021
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@knative-prow-robot knative-prow-robot merged commit 0bfa8de into knative:main Apr 29, 2021
matzew added a commit to matzew/eventing that referenced this pull request Apr 29, 2021
…ve#5319

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
openshift-merge-robot pushed a commit to openshift/knative-eventing that referenced this pull request Apr 29, 2021
…ve#5319 (#1230)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants