Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: Document changes since v0.4.0 #772

Merged
merged 1 commit into from
Dec 3, 2018
Merged

CHANGELOG: Document changes since v0.4.0 #772

merged 1 commit into from
Dec 3, 2018

Conversation

wking
Copy link
Member

@wking wking commented Dec 2, 2018

Through 12ef0cb (#748).

I'd like to pin the OpenShift release payload and OS image, we're blocked by not having those images pushed to quay.io (where they'll have a longer expiration time). CC @smarterclayton

Also, #757 is still in flight, but I'd be fine pinning this installer release with cherry-picks from there or any other hack if we had an OpenShift image we could pin to that would survive the week.

CC @abhinavdahiya, @crawford

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2018
@wking wking force-pushed the version-0.5.0 branch 5 times, most recently from b4589db to b35908c Compare December 2, 2018 06:13
@wking
Copy link
Member Author

wking commented Dec 2, 2018

Also CC @flaper87. I think I've summarized #722 and #726 appropriately, but let me know if you want changes there or want to add any other OpenStack discussion to these notes.

@smarterclayton
Copy link
Contributor

smarterclayton commented Dec 2, 2018 via email

abhinavdahiya
abhinavdahiya reviewed Dec 2, 2018
View reviewed changes
CHANGELOG.md
- On AWS, master volume size has been bumped from 30 GiB to 120 GiB to
increase our baseline performance from on [gp2's sliding IOPS
scale][aws-ebs-gp2-iops] from the 100 IOPS floor up to 360 IOPS.
Volume information is not currently supported by [the cluster-API
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this belongs in Changelog

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this belongs in Changelog

The whole entry? Just the cluster-API caveat?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinavdahiya bump

Copy link
Contributor

@abhinavdahiya abhinavdahiya Dec 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS provider's
AWSMachineProviderConfig][cluster-api-provider-aws-012575c1-AWSMachineProviderConfig],
so this change is currently limited to masters created by the
installer.

this part

EDIT: the entire part regarding cluster-api.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could leave that off. We don't support scaling masters anyway. @wking what do you think? I could go either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support scaling masters anyway.

Doesn't the cluster API bring a master back up if it dies (because someone accidentally deletes it in the AWS console, I dunno)? That would hit this limitation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but etcd wouldn't come up. Let's go ahead and leave that note since I think it may prove helpful to our future selves.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but etcd wouldn't come up.

Ah. I was hoping coming up with the same hostname would be enough to get back into the cluster ;). But maybe it needs a secret that would have been lost with the old volume.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The etcd client has an internal ID that will be different when the replacement comes up. The cluster will not let that client participate until it has been joined.

abhinavdahiya
abhinavdahiya reviewed Dec 2, 2018
View reviewed changes
@wking wking mentioned this pull request Dec 2, 2018
Closed
@wking
Copy link
Member Author

wking commented Dec 3, 2018

I've pushed fc0e947 -> dcb3909, rebasing onto master now that #760 has landed. I've also updated the docs to make try.openshift.io secrets required, since #773 is pinning us to private images that need the quay.io secret.

@crawford
Copy link
Contributor

crawford commented Dec 3, 2018

/retest

crawford
crawford reviewed Dec 3, 2018
View reviewed changes
crawford
crawford reviewed Dec 3, 2018
View reviewed changes
@wking
CHANGELOG: Document changes since v0.4.0
c2263f6 
Through 6585f5d (Merge pull request openshift#775 from
wking/pull-secret-for-bootkube.sh, 2018-12-03).
wking added a commit to wking/openshift-installer that referenced this pull request Dec 3, 2018
@wking
pkg: Pin to RHCOS 47.167 and quay.io/openshift-release-dev/ocp-releas…
43e1458 
…e:4.0.0-3

That's the latest RHCOS release:

  $ curl -s https://releases-rhcos.svc.ci.openshift.org/storage/releases/maipo/builds.json | jq '{latest: .builds[0], timestamp}'
  {
    "latest": "47.165",
    "timestamp": "2018-12-02T06:41:22Z"
  }

And Clayton just pushed 4.0.0-0.alpha-2018-12-02-020136 to
quay.io/openshift-release-dev/ocp-release:4.0.0-3 [1].

Renaming OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE gets us CI testing
of the pinned release despite openshift/release@60007df2 (Use
RELEASE_IMAGE_LATEST for CVO payload, 2018-10-03,
openshift/release#1793).

[1]: openshift#772 (comment)
@wking
Copy link
Member Author

wking commented Dec 3, 2018

Pipeline broken? I'm seeing errors like:

error: build error: stat /tmp/build/inputs/clonerefs: no such file or directory

/retest

@wking
Copy link
Member Author

wking commented Dec 3, 2018

/retest

@stevekuznetsov fixed something ;).

@wking
Copy link
Member Author

wking commented Dec 3, 2018

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2018 •
edited
Loading

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt fc0e94752d0d85957f46d4a3147f8f479c425d18 link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Dec 3, 2018

/test images

@crawford
Copy link
Contributor

crawford commented Dec 3, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Dec 3, 2018

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4f4965e into openshift:master Dec 3, 2018
@wking wking deleted the version-0.5.0 branch December 3, 2018 23:32
wking added a commit to wking/openshift-installer that referenced this pull request Dec 4, 2018
@wking
CHANGELOG: Add a closing paren to AWS instance types
758edfc 
Fixing a typo from c2263f6 (CHANGELOG: Document changes since v0.4.0,
2018-12-01, openshift#772).
@wking wking mentioned this pull request Dec 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford crawford left review comments

@abhinavdahiya abhinavdahiya abhinavdahiya left review comments

@staebler staebler Awaiting requested review from staebler

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@crawford crawford

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wking @smarterclayton @crawford @openshift-ci-robot @abhinavdahiya @openshift-merge-robot