Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the ApiVersion to the correct awsproviderconfig.k8s.io/v1alpha1 #748

Conversation

ingvagabund
Copy link
Member

Since migration to CRD the ApiVersion string changed into awsproviderconfig.k8s.io/v1alpha1.
It needs to be reflected on the installer side.

Since migration to CRD the ApiVersion string changed into awsproviderconfig.k8s.io/v1alpha1.
It needs to be reflected on the installer side.
@ingvagabund
Copy link
Member Author

/test e2e-libvirt

@ingvagabund
Copy link
Member Author

/retest

@abhinavdahiya
Copy link
Contributor

@ingvagabund ref to Since migration to CRD the ApiVersion string changed into awsproviderconfig.k8s.io/v1alpha1. Can you also cross-link that PR. Thanks!

@abhinavdahiya
Copy link
Contributor

/approve

/retest

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2018
@wking
Copy link
Member

wking commented Nov 28, 2018

Looks like this may be catching us up with openshift/cluster-api-provider-aws@69d1882 (openshift/cluster-api-provider-aws#67).

@abhinavdahiya
Copy link
Contributor

/retest

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 28, 2018

@ingvagabund ref to Since migration to CRD the ApiVersion string changed into awsproviderconfig.k8s.io/v1alpha1. Can you also cross-link that PR. Thanks!

PR here: openshift/cluster-api-provider-aws#81
commit from the PR: openshift/cluster-api-provider-aws@69d1882#diff-fe54bc4a2106231516f23ae0c2e2dc8aR34

Do you want the PR number in the commit message as well?

@ingvagabund
Copy link
Member Author

The PR @wking referenced is from crd branch which we used for testing and development before applying the changes in the master branch.

@ingvagabund
Copy link
Member Author

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

@abhinavdahiya anyway to figure out why are both actuator tests failing?

@ingvagabund
Copy link
Member Author

/retest

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 12ef0cb into openshift:master Dec 1, 2018
@openshift-ci-robot
Copy link
Contributor

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt 7c1017e link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund ingvagabund deleted the change-machine-apiversion branch December 1, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants