Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1883674: Replace operand image #88

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Checkout the sources
$ git clone https://github.com/openshift/cluster-nfd-operator $GOPATH/src/github.com/openshift/cluster-nfd-operator
```

Update the `Makefile` and edit `IMAGE_TAG` and `IMAGE_REGISTRY` one will need those later to update the operator manifest (`image: $IMAGE_REGISTRY/$IMAGE_TAG`).
Update the `Makefile` and edit `IMAGE`, `ORG` and `REGISTRY` one will need those later to update the operator manifest (`image: $(REGISTRY)/$(ORG)/$(cluster-nfd-operator:$(TAG))`).

Update the Dockerfile with the correct golang build image and the base image the operator will run with.

Expand Down
2 changes: 1 addition & 1 deletion assets/node-feature-discovery/05-nfd-daemonset.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ spec:
valueFrom:
fieldRef:
fieldPath: spec.nodeName
image: quay.io/zvonkok/node-feature-discovery:v4.0
image: quay.io/openshift/origin-node-feature-discovery:4.6
name: node-feature-discovery
command: ["/usr/bin/node-feature-discovery"]
args:
Expand Down
2 changes: 1 addition & 1 deletion manifests/0600_operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
- name: OPERATOR_NAME
value: "cluster-nfd-operator"
- name: NODE_FEATURE_DISCOVERY_IMAGE
value: "quay.io/zvonkok/node-feature-discovery:v4.2"
value: "quay.io/openshift/origin-node-feature-discovery:4.6"
securityContext:
readOnlyRootFilesystem: true
allowPrivilegeEscalation: false
Expand Down
2 changes: 1 addition & 1 deletion manifests/0700_cr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ metadata:
namespace: REPLACE_NAMESPACE
spec:
namespace: openshift-nfd
image: quay.io/zvonkok/node-feature-discovery:v4.2
image: quay.io/openshift/origin-node-feature-discovery:4.6
2 changes: 1 addition & 1 deletion pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
)

const (
nodeFeatureDiscoveryImageDefault string = "quay.io/openshift-psap/node-feature-discovery:latest"
nodeFeatureDiscoveryImageDefault string = "quay.io/openshift/origin-node-feature-discovery:4.6"
operatorNameDefault string = "node-feature-discovery"
operatorNamespaceDefault string = "openshift-nfd-operator"
resyncPeriodDefault int64 = 600
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ var (
cleanupTimeout = time.Second * 30
opName = "nfd-master-client"
opNamespace = "openshift-nfd"
opImage = "quay.io/zvonkok/node-feature-discovery:v4.2"
opImage = "quay.io/openshift/origin-node-feature-discovery:4.6"
//opImage = "registry.svc.ci.openshift.org/openshift/node-feature-discovery-container:v4.2"
)

Expand Down