Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1883674: Replace operand image #88

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Bug 1883674: Replace operand image #88

merged 5 commits into from
Sep 30, 2020

Conversation

ArangoGutierrez
Copy link
Contributor

Replace target for operand image registry

zvonkok -> kubernetes_incubator

Upstream operand image can be found at:

quay.io/kubernetes_incubator/node-feature-discovery

Signed-off-by: Carlos Eduardo Arango Gutierrez carangog@redhat.com

@ArangoGutierrez
Replace operand image
f6c65f9 
Replace target for operand image registry

    zvonkok -> kubernetes_incubator

Upstream operand image can be found at:

    quay.io/kubernetes_incubator/node-feature-discovery

Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Copy link
Contributor Author

/assign @zvonkok

@zvonkok
Copy link
Contributor

zvonkok commented Jun 24, 2020

@ArangoGutierrez We need the downstream node-feature-discovery image here not the upstream. You have setup the mirroring for the operator and the operand. We need here the mirrored operand image.

@ArangoGutierrez
Copy link
Contributor Author

You are totally right, and also to make sense with #81 , will fix that asap

@ArangoGutierrez
empty commit
fa8920f 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Merge branch 'master' of github.com:openshift/cluster-nfd-operator in…
254f651 
…to upstream_backport
@ArangoGutierrez
Copy link
Contributor Author

@zvonkok PR has been fixed according to your comments, PTAL

@ArangoGutierrez
Copy link
Contributor Author

/test e2e-aws-upgrade

1 similar comment
@ArangoGutierrez
Copy link
Contributor Author

/test e2e-aws-upgrade

@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez
Copy link
Contributor Author

ArangoGutierrez commented Sep 22, 2020 via email

@ArangoGutierrez
Copy link
Contributor Author

/test e2e-upgrade

@ArangoGutierrez
Merge branch 'master' of github.com:openshift/cluster-nfd-operator in…
db9b742 
…to upstream_backport
@ArangoGutierrez
use downstream image
b24d0ec 
Signed-off-by: Carlos Eduardo Arango Gutierrez <carangog@redhat.com>
@ArangoGutierrez
Copy link
Contributor Author

@ArangoGutierrez We need the downstream node-feature-discovery image here not the upstream. You have setup the mirroring for the operator and the operand. We need here the mirrored operand image.

b24d0ec uses downstream image openshift/origin-node-feature-discovery

@zvonkok
Copy link
Contributor

zvonkok commented Sep 29, 2020

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArangoGutierrez, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@ArangoGutierrez ArangoGutierrez changed the title Replace operand image Bug 1883674: Replace operand image Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@ArangoGutierrez: This pull request references Bugzilla bug 1883674, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883674: Replace operand image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 29, 2020
@ArangoGutierrez
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@ArangoGutierrez: This pull request references Bugzilla bug 1883674, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ArangoGutierrez
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Sep 29, 2020
@openshift-ci-robot
Copy link
Contributor

@ArangoGutierrez: This pull request references Bugzilla bug 1883674, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e4a39a0 into openshift:master Sep 30, 2020
@openshift-ci-robot
Copy link
Contributor

@ArangoGutierrez: All pull requests linked via external trackers have merged:

Bugzilla bug 1883674 has been moved to the MODIFIED state.

In response to this:

Bug 1883674: Replace operand image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

@jmencak jmencak Awaiting requested review from jmencak

Assignees

@zvonkok zvonkok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArangoGutierrez @zvonkok @openshift-ci-robot @openshift-bot @openshift-merge-robot