Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPEDGE-1435: bump(library-go,ocp/api,ocp/client-go) #1378

Merged

Conversation

eggfoobar
Copy link
Contributor

updating dependencies for the arbiter node feature

updating dependencies for the arbiter node feature

Signed-off-by: ehila <ehila@redhat.com>
@tjungblu
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@tjungblu
Copy link
Contributor

/retest

@eggfoobar eggfoobar changed the title bump(library-go,ocp/api,ocp/client-go) OCPEDGE-1435: bump(library-go,ocp/api,ocp/client-go) Dec 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 17, 2024

@eggfoobar: This pull request references OCPEDGE-1435 which is a valid jira issue.

In response to this:

updating dependencies for the arbiter node feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ec243c9 and 2 for PR HEAD 00be707 in total

@eggfoobar
Copy link
Contributor Author

/retest-required

@eggfoobar
Copy link
Contributor Author

It seems aws-ovn-serial is currently failing due to tests that are no longer needed, once openshift/origin#29383 is merged in that should resolve this failure.

@tjungblu Not sure if you want to wait for that to be merged in or override it, I'm fine with either

@tjungblu
Copy link
Contributor

yeah that doesn't seem related to this PR at all.

/override ci/prow/e2e-aws-ovn-serial

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-serial

In response to this:

yeah that doesn't seem related to this PR at all.

/override ci/prow/e2e-aws-ovn-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 00be707 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-metal-ovn-sno-cert-rotation-shutdown 00be707 link false /test e2e-metal-ovn-sno-cert-rotation-shutdown
ci/prow/okd-scos-e2e-aws-ovn 00be707 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-etcd-certrotation 00be707 link false /test e2e-aws-etcd-certrotation
ci/prow/e2e-metal-ovn-ha-cert-rotation-shutdown 00be707 link false /test e2e-metal-ovn-ha-cert-rotation-shutdown

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 70a937e into openshift:master Dec 18, 2024
13 of 18 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-etcd-operator
This PR has been included in build cluster-etcd-operator-container-v4.19.0-202412181141.p0.g70a937e.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants