OCPEDGE-1195: Arbiter node support #1366
Conversation
af05a05 to
8425218
Compare
|
@eggfoobar: This pull request references OCPEDGE-1195 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
79888aa to
4073cbc
Compare
|
@eggfoobar: This pull request references OCPEDGE-1195 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Hold for #1378 to be merged in, so we don't do the dependencies update in this PR |
pkg/operator/starter.go
Outdated
| var hasArbiterTopology bool | ||
| if infra, err := configClient.ConfigV1().Infrastructures().Get(ctx, ceohelpers.InfrastructureClusterName, metav1.GetOptions{}); err != nil { | ||
| return err | ||
| } else { | ||
| hasArbiterTopology = infra.Status.ControlPlaneTopology == configv1.HighlyAvailableArbiterMode | ||
| } |
There was a problem hiding this comment.
can we move this into one of our helpers?
we have https://github.com/openshift/cluster-etcd-operator/blob/master/pkg/operator/ceohelpers/control_plane_topology.go#L26 for SNO already
There was a problem hiding this comment.
Oh I like that, looks cleaner too, thanks! I did need to keep it an interface client still since we query it before the informers start.
Signed-off-by: ehila <ehila@redhat.com> feat: updated starter logic to conditionally use the arbiter node added unit tests for multiselector informer and lister Signed-off-by: ehila <ehila@redhat.com>
4073cbc to
4e618bb
Compare
|
/unhold Dependency PR has merged in, unholding |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eggfoobar, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
/override ci/prow/e2e-aws-ovn-etcd-scaling unrelated failure |
|
@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cee7f9b
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: cluster-etcd-operator |
Per EP: openshift/enhancements#1674
This PR adds the ability of CEO to be able to be aware of the arbiter node in order to correctly deploy an etcd member on an arbiter node. This change bumps ocp/api in order to pull in the new control plane topology of
HighlyAvailableArbiterand bumps ocp/library-go in order to use the updated static pod builder that allows for selecting master and arbiter nodes for static pods.