OCPBUGS-17199: Separated the revision stability check from the bootstrap completeness check #1360
Conversation
|
@jubittajohn: This pull request references Jira Issue OCPBUGS-17199, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-metal-assisted |
pkg/operator/ceohelpers/bootstrap.go
Outdated
| if shouldRunRevisionStabilityCheck { | ||
| _, status, _, err := staticPodClient.GetStaticPodOperatorState() | ||
| if err != nil { | ||
| return false, fmt.Errorf("failed to get static pod operator state: %w", err) | ||
| } | ||
| if status.LatestAvailableRevision == 0 { |
There was a problem hiding this comment.
I would start to split out those functions and have one for "IsBootstrapComplete" and one for "IsRevisionStable".
etcdendpointscontroller.go and the check above can then just use the IsRevisionStable function alongside the IsBootstrapComplete - the others can stay as they are
|
@jubittajohn: This pull request references Jira Issue OCPBUGS-17199, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
0e12674 to
7976cdf
Compare
|
/test e2e-metal-assisted |
63216b4 to
c237575
Compare
|
/test e2e-metal-assisted |
|
/test unit |
|
/test e2e-aws-ovn-etcd-scaling |
|
/test e2e-aws-ovn-single-node |
|
/payload-aggregate periodic-ci-openshift-cluster-control-plane-machine-set-operator-release-4.18-periodics-e2e-aws 10 |
|
@jubittajohn: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/214bf780-9acb-11ef-8530-2536f6b242fa-0 |
|
/retest |
28397e5 to
7522927
Compare
|
/test e2e-metal-assisted |
|
/retest-required |
pkg/operator/ceohelpers/bootstrap.go
Outdated
| } | ||
|
|
||
| // while bootstrapping and when revision is stabilising, scaling should be considered safe always | ||
| if !bootstrapComplete || !revisionStable { |
There was a problem hiding this comment.
I know it's not an expensive call, but feel free to early exit on the first check already. There's no sense in checking revision stability if the bootstrap is not completed yet
…s check Signed-off-by: jubittajohn <jujohn@redhat.com>
cd75e92 to
8ffe961
Compare
|
/test e2e-metal-assisted |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jubittajohn, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jubittajohn: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold cancel |
7d0e358
into
openshift:master
|
@jubittajohn: Jira Issue OCPBUGS-17199: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-17199 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-etcd-operator |
Separated the revision stability check from the bootstrap completeness check to ensure the revision stability check is only called from controllers that need them.