Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "OCPBUGS-17199: remove revision stability check from bootstrap complet…" #1167

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Revert "OCPBUGS-17199: remove revision stability check from bootstrap complet…" #1167

merged 1 commit into from
Nov 28, 2023

Conversation

tjungblu
Copy link
Contributor

Reverts #1087

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 27, 2023
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-17199, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Verified instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #1087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from Elbehery and hasbro17 November 27, 2023 14:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@Elbehery
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

@tjungblu: The following commands are available to trigger required jobs:

  • /test configmap-scale
  • /test e2e-agnostic-ovn
  • /test e2e-agnostic-ovn-upgrade
  • /test e2e-aws-ovn-etcd-scaling
  • /test e2e-aws-ovn-serial
  • /test e2e-aws-ovn-single-node
  • /test e2e-operator
  • /test images
  • /test unit
  • /test verify
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-aws
  • /test e2e-aws-disruptive
  • /test e2e-aws-disruptive-ovn
  • /test e2e-aws-etcd-recovery
  • /test e2e-azure
  • /test e2e-azure-ovn-etcd-scaling
  • /test e2e-gcp
  • /test e2e-gcp-disruptive
  • /test e2e-gcp-disruptive-ovn
  • /test e2e-gcp-ovn-etcd-scaling
  • /test e2e-gcp-qe-no-capabilities
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-metal-ipi-serial-ipv4
  • /test e2e-metal-single-node-live-iso
  • /test e2e-operator-fips
  • /test e2e-vsphere-ovn-etcd-scaling

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn-upgrade
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-etcd-recovery
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-etcd-scaling
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator-fips
  • pull-ci-openshift-cluster-etcd-operator-master-images
  • pull-ci-openshift-cluster-etcd-operator-master-unit
  • pull-ci-openshift-cluster-etcd-operator-master-verify
  • pull-ci-openshift-cluster-etcd-operator-master-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/test e2e-metal-assisted

@tjungblu
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 27, 2023
@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-17199, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sandeepknd

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from sandeepknd November 27, 2023 16:27
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD eb39137 and 2 for PR HEAD c701f39 in total

@Elbehery
Copy link
Contributor

/retest-required

1 similar comment
@Elbehery
Copy link
Contributor

/retest-required

@tjungblu
Copy link
Contributor Author

overriding the no capabilities job, seems to be monitoring related

/override e2e-gcp-qe-no-capabilities

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@tjungblu: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-gcp-qe-no-capabilities

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-agnostic-ovn
  • ci/prow/e2e-agnostic-ovn-upgrade
  • ci/prow/e2e-aws-etcd-recovery
  • ci/prow/e2e-aws-ovn-etcd-scaling
  • ci/prow/e2e-aws-ovn-serial
  • ci/prow/e2e-aws-ovn-single-node
  • ci/prow/e2e-gcp-qe-no-capabilities
  • ci/prow/e2e-metal-assisted
  • ci/prow/e2e-operator
  • ci/prow/e2e-operator-fips
  • ci/prow/images
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-agnostic-ovn-upgrade
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-etcd-recovery
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-etcd-scaling
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-serial
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-aws-ovn-single-node
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-gcp-qe-no-capabilities
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-metal-assisted
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator
  • pull-ci-openshift-cluster-etcd-operator-master-e2e-operator-fips
  • pull-ci-openshift-cluster-etcd-operator-master-images
  • pull-ci-openshift-cluster-etcd-operator-master-unit
  • pull-ci-openshift-cluster-etcd-operator-master-verify
  • pull-ci-openshift-cluster-etcd-operator-master-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

overriding the no capabilities job, seems to be monitoring related

/override e2e-gcp-qe-no-capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link
Contributor Author

/override ci/prow/e2e-gcp-qe-no-capabilities

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-gcp-qe-no-capabilities

In response to this:

/override ci/prow/e2e-gcp-qe-no-capabilities

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@tjungblu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery c701f39 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5d5f8b1 into openshift:master Nov 28, 2023
@tjungblu tjungblu deleted the revert-1087-OCPBUGS-14673-rev branch November 28, 2023 08:28
@openshift-ci-robot
Copy link

@tjungblu: Jira Issue OCPBUGS-17199: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17199 has been moved to the MODIFIED state.

In response to this:

Reverts #1087

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.15.0-202311280949.p0.g5d5f8b1.assembly.stream for distgit cluster-etcd-operator.
All builds following this will include this PR.

This was referenced Oct 10, 2024
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elbehery Elbehery Awaiting requested review from Elbehery

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@sandeepknd sandeepknd Awaiting requested review from sandeepknd

Assignees

@Elbehery Elbehery

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tjungblu @openshift-ci-robot @Elbehery @openshift-bot