Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1754115: Boot from volume #70

Merged
merged 2 commits into from
Sep 26, 2019
Merged

Bug 1754115: Boot from volume #70

merged 2 commits into from
Sep 26, 2019

Conversation

iamemilio
Copy link

@iamemilio iamemilio commented Sep 25, 2019 •
edited
Loading

Backport to 4.2

Author: @Fedosin
Upstream PR: #69

@openshift-ci-robot
Copy link

@iamemilio: This pull request references Bugzilla bug 1754115, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug 1754070 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1754115: Boot from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 25, 2019
@openshift-ci-robot
Copy link

@iamemilio: This pull request references Bugzilla bug 1754115, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug 1754070 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1754115: Boot from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

@iamemilio: This pull request references Bugzilla bug 1754115, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug 1754070 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1754115: Boot from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamemilio iamemilio changed the base branch from master to release-4.2 September 25, 2019 21:02
@openshift-ci-robot
Copy link

@iamemilio: This pull request references Bugzilla bug 1754115, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug 1754070 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1754115: Boot from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link

@openshift-bot: This pull request references Bugzilla bug 1754115, which is invalid:

  • expected dependent Bugzilla bug 1754070 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iamemilio
Copy link
Author

Needs approval from @eparis

@eparis eparis added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2019
@iamemilio
Copy link
Author

/lgtm

@openshift-ci-robot
Copy link

@iamemilio: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Member

mandre commented Sep 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamemilio, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis eparis removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit 52a3e24 into openshift:release-4.2 Sep 26, 2019
@openshift-ci-robot
Copy link

@iamemilio: All pull requests linked via external trackers have merged. Bugzilla bug 1754115 has been moved to the MODIFIED state.

In response to this:

Bug 1754115: Boot from volume

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Mar 27, 2020
@flaper87 @k8s-ci-robot
Let clientconfig create the AuthOptions instance (openshift#70)
d72adf0 
We were creating our own copy of AuthOptions rather than relying on the
utilities provided by clientconfig. Our copy didn't have all the info
required by gophercloud to authenticate.

Closes openshift#69
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
racheljpg pushed a commit to racheljpg/cluster-api-provider-openstack that referenced this pull request Dec 20, 2023
@flaper87
Let clientconfig create the AuthOptions instance (openshift#70)
39d1b06 
We were creating our own copy of AuthOptions rather than relying on the
utilities provided by clientconfig. Our copy didn't have all the info
required by gophercloud to authenticate.

Closes openshift#69
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@flaper87 @pierreprinetti
Let clientconfig create the AuthOptions instance (openshift#70)
bb1f942 
We were creating our own copy of AuthOptions rather than relying on the
utilities provided by clientconfig. Our copy didn't have all the info
required by gophercloud to authenticate.

Closes openshift#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fedosin Fedosin Awaiting requested review from Fedosin

@tomassedovic tomassedovic Awaiting requested review from tomassedovic

Assignees

@mandre mandre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@iamemilio @openshift-ci-robot @openshift-bot @mandre @eparis @openshift-merge-robot @Fedosin