Bug 1754070: Add boot from volume support #69
Conversation
| // VolumeSize: config.RootVolume.Size, | ||
| VolumeSize: 25, | ||
| // DeviceType: config.RootVolume.DeviceType, | ||
| DeviceType: "performance", |
There was a problem hiding this comment.
DeviceType is not right, it should be VolumeType instead.
There was a problem hiding this comment.
VolumeType was added in Stein, so we can't rely on it if we want to support OSP13 😢
https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id60
66200c1 to
5f0f158
Compare
|
No idea why dep removed vendor/github.com/openshift/kubernetes-drain mfedosin@winter ~/go/src/sigs.k8s.io/cluster-api-provider-openstack $ git s |
5f0f158 to
37f5ef0
Compare
| DeleteOnTermination: true, | ||
| DestinationType: bootfromvolume.DestinationVolume, | ||
| VolumeSize: config.RootVolume.Size, | ||
| DeviceType: config.RootVolume.DeviceType, | ||
| } | ||
| blocks = append(blocks, block) | ||
|
|
||
| createOpts = bootfromvolume.CreateOptsExt{ |
There was a problem hiding this comment.
Can you please take this opportunity to move here the declaration of createOpts? I find it confusing to have it so far away (line 426).
37f5ef0 to
b8017a1
Compare
e10ad65 to
87e0440
Compare
| @@ -608,22 +617,45 @@ func (is *InstanceService) InstanceCreate(clusterName string, name string, clust | |||
| if config.RootVolume != nil && config.RootVolume.Size != 0 { | |||
| var blocks []bootfromvolume.BlockDevice | |||
|
|
|||
| imageID, err := getImageID(is, config.RootVolume.SourceUUID) | |||
| if err != nil { | |||
| return nil, fmt.Errorf("Create new server err: %v", err) | |||
There was a problem hiding this comment.
This error message could be a bit more specific.
87e0440 to
b66e31a
Compare
b66e31a to
e7d193b
Compare
|
@Fedosin: This pull request references Bugzilla bug 1754115, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Fedosin: This pull request references Bugzilla bug 1754070, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1754070 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We were creating our own copy of AuthOptions rather than relying on the utilities provided by clientconfig. Our copy didn't have all the info required by gophercloud to authenticate. Closes openshift#69
We were creating our own copy of AuthOptions rather than relying on the utilities provided by clientconfig. Our copy didn't have all the info required by gophercloud to authenticate. Closes openshift#69
We were creating our own copy of AuthOptions rather than relying on the utilities provided by clientconfig. Our copy didn't have all the info required by gophercloud to authenticate. Closes openshift#69
No description provided.