Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Migrating from glide to go mod #126

Closed
wants to merge 9 commits into from
Closed

WIP - Migrating from glide to go mod #126

wants to merge 9 commits into from

Conversation

ricardomaraschini
Copy link
Contributor

Migrating from glide to go mod.

This patch removes old glide files and adds support for go mod. All
packages got vendored again.
As code-generator is not a codebase dependency but a build dependency
instead, go mod was not able to add it to our list of dependencies. This
patch adds the code-generator repo inside hack and use it instead of the
old glide vendored dependency.
This patch migrates the script that does dependency updates to use go
mod instead of glide.
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 3, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ricardomaraschini
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ricardomaraschini ricardomaraschini changed the title Migrating from glide to go mod WIP - Migrating from glide to go mod Dec 3, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2019
@openshift-ci-robot
Copy link

@ricardomaraschini: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/verify ba871c2 link /test verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants