Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1769008: Importing new "imageregistry" and "samples" types from openshift/api #123

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Bug 1769008: Importing new "imageregistry" and "samples" types from openshift/api #123

merged 3 commits into from
Dec 5, 2019

Conversation

ricardomaraschini
Copy link
Contributor

@ricardomaraschini ricardomaraschini commented Nov 22, 2019 •
edited
Loading

  • Updates openshift/api dependency.
  • Generated clientset, informers and listers for imageregistry.
  • Generated clientset, informers and listers for samples.

@ricardomaraschini
Bump(*) - Updating openshift/api dependency.

Verified

This commit was signed with the committer’s verified signature.
janniks janniks
GPG key ID: B858531477B9D40C
Verified
Learn about vigilant mode
e212bb9 
Updates openshift/api to include imageregistry types definitions.
@ricardomaraschini
Added clientset, informers and listers for imageregistry.

Verified

This commit was signed with the committer’s verified signature.
janniks janniks
GPG key ID: B858531477B9D40C
Verified
Learn about vigilant mode
2d42c8b
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1769008, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1769008: Importing new imageregistry types from openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 22, 2019
@ricardomaraschini
Copy link
Contributor Author

/assign @adambkaplan @dmage @gabemontero

@dmage
Copy link
Contributor

dmage commented Nov 22, 2019

/assign @deads2k

gabemontero
gabemontero reviewed Nov 22, 2019
View reviewed changes
@ricardomaraschini
Added clientset, informers and listers for Samples.

Verified

This commit was signed with the committer’s verified signature.
janniks janniks
GPG key ID: B858531477B9D40C
Verified
Learn about vigilant mode
f899ff2
@openshift-ci-robot
Copy link

@ricardomaraschini: This pull request references Bugzilla bug 1769008, which is valid.

In response to this:

Bug 1769008: Importing new imageregistry types from openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini ricardomaraschini changed the title Bug 1769008: Importing new imageregistry types from openshift/api Bug 1769008: Importing new "imageregistry" and "samples" types from openshift/api Nov 22, 2019
adambkaplan
adambkaplan approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2019
@adambkaplan
Copy link
Contributor

@soltysh @sttts shouldn't client-go be updated to use go.mod?

@sttts
Copy link
Contributor

sttts commented Nov 25, 2019

@soltysh @sttts shouldn't client-go be updated to use go.mod?

It should if it isn't. Anybody with free cycles?

@ricardomaraschini
Copy link
Contributor Author

ricardomaraschini commented Dec 3, 2019 •
edited
Loading

@sttts @adambkaplan I am working on a separate PR to port this to go mod on
#126

@soltysh
Copy link

soltysh commented Dec 3, 2019

It would be nice to have a set of PRs, api and client-go switched to go.mod

adambkaplan
adambkaplan approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@deads2k
Copy link
Contributor

deads2k commented Dec 5, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, deads2k, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9faca51 into openshift:master Dec 5, 2019
@openshift-ci-robot
Copy link

@ricardomaraschini: All pull requests linked via external trackers have merged. Bugzilla bug 1769008 has been moved to the MODIFIED state.

In response to this:

Bug 1769008: Importing new "imageregistry" and "samples" types from openshift/api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero mentioned this pull request Dec 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero

@adambkaplan adambkaplan

@smarterclayton smarterclayton

@sttts sttts

Assignees

@dmage dmage

@adambkaplan adambkaplan

@gabemontero gabemontero

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ricardomaraschini @openshift-ci-robot @dmage @adambkaplan @sttts @soltysh @deads2k @gabemontero @openshift-merge-robot