Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that verifies replayer function when waiting a minute between requests #637

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented May 6, 2024

Description

Add test that verifies replayer function when waiting a minute between requests
Adds functionality within E2E test suite to explicitly reuse connection for requests

This was created in part to trigger potential edge cases that could have been associated with ReadTimeoutHandler bug

  • Category: Enhancement
  • Why these changes are required? Verify no impact for bug
  • What is the old behavior before changes and new behavior after changes? New test case

Issues Resolved

MIGRATIONS-1722

Is this a backport? If so, please add backport PR # and/or commits #

Testing

E2E testing, verified bug is triggered during test case

Check List

  • [ x] New functionality includes testing
    • [x ] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait force-pushed the E2EWaitBetweenRequestsOnConnection branch 3 times, most recently from 3a0ba07 to 426dc35 Compare May 7, 2024 12:28
@AndreKurait AndreKurait marked this pull request as ready for review May 8, 2024 16:19
test/tests.py Outdated Show resolved Hide resolved
test/tests.py Show resolved Hide resolved
test/tests.py Show resolved Hide resolved
@AndreKurait AndreKurait force-pushed the E2EWaitBetweenRequestsOnConnection branch from c0d6c51 to 3eb8fd7 Compare May 9, 2024 18:06
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (38cfe19) to head (66928e8).
Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #637      +/-   ##
============================================
- Coverage     75.60%   75.50%   -0.10%     
+ Complexity     1541     1539       -2     
============================================
  Files           168      168              
  Lines          6455     6455              
  Branches        575      575              
============================================
- Hits           4880     4874       -6     
- Misses         1192     1199       +7     
+ Partials        383      382       -1     
Flag Coverage Δ
unittests 75.50% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait force-pushed the E2EWaitBetweenRequestsOnConnection branch 2 times, most recently from b717381 to 66928e8 Compare May 13, 2024 17:25
…n requests

Signed-off-by: Andre Kurait <akurait@amazon.com>
…y session httpAdapter

Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait force-pushed the E2EWaitBetweenRequestsOnConnection branch from 66928e8 to 82690c5 Compare May 16, 2024 18:24
@AndreKurait AndreKurait merged commit 121ba5d into opensearch-project:main May 16, 2024
6 checks passed
@AndreKurait AndreKurait deleted the E2EWaitBetweenRequestsOnConnection branch May 16, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants