-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test that verifies replayer function when waiting a minute between requests #637
Merged
AndreKurait
merged 2 commits into
opensearch-project:main
from
AndreKurait:E2EWaitBetweenRequestsOnConnection
May 16, 2024
Merged
Add test that verifies replayer function when waiting a minute between requests #637
AndreKurait
merged 2 commits into
opensearch-project:main
from
AndreKurait:E2EWaitBetweenRequestsOnConnection
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3a0ba07
to
426dc35
Compare
gregschohn
reviewed
May 9, 2024
c0d6c51
to
3eb8fd7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
============================================
- Coverage 75.60% 75.50% -0.10%
+ Complexity 1541 1539 -2
============================================
Files 168 168
Lines 6455 6455
Branches 575 575
============================================
- Hits 4880 4874 -6
- Misses 1192 1199 +7
+ Partials 383 382 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b717381
to
66928e8
Compare
peternied
reviewed
May 13, 2024
gregschohn
approved these changes
May 15, 2024
peternied
approved these changes
May 15, 2024
…n requests Signed-off-by: Andre Kurait <akurait@amazon.com>
…y session httpAdapter Signed-off-by: Andre Kurait <akurait@amazon.com>
66928e8
to
82690c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test that verifies replayer function when waiting a minute between requests
Adds functionality within E2E test suite to explicitly reuse connection for requests
This was created in part to trigger potential edge cases that could have been associated with ReadTimeoutHandler bug
Issues Resolved
MIGRATIONS-1722
Is this a backport? If so, please add backport PR # and/or commits #
Testing
E2E testing, verified bug is triggered during test case
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.