Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E large request test #636

Merged
merged 3 commits into from
May 16, 2024

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented May 6, 2024

Description

Add E2E large request test
Fix documentation for E2E target_password

This task builds on top of #637

  • Category: Enhancement
  • Why these changes are required? Current E2E script misses tests on large requests which can have differing behavior
  • What is the old behavior before changes and new behavior after changes? New Test which checks behavior for 20MB requests

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Ran tests

Check List

  • [ x] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@AndreKurait AndreKurait force-pushed the E2ELargeRequestCDC branch 3 times, most recently from d031ee0 to dc50e3d Compare May 13, 2024 17:32
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (82690c5) to head (c2d7337).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #636      +/-   ##
============================================
- Coverage     75.64%   75.61%   -0.04%     
+ Complexity     1542     1541       -1     
============================================
  Files           168      168              
  Lines          6455     6455              
  Branches        575      575              
============================================
- Hits           4883     4881       -2     
- Misses         1190     1191       +1     
- Partials        382      383       +1     
Flag Coverage Δ
unittests 75.61% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait force-pushed the E2ELargeRequestCDC branch 5 times, most recently from af1f7c3 to 4e4fdb6 Compare May 14, 2024 13:55
@AndreKurait AndreKurait marked this pull request as ready for review May 14, 2024 13:55
test/tests.py Outdated Show resolved Hide resolved
test/tests.py Outdated Show resolved Hide resolved
@AndreKurait AndreKurait force-pushed the E2ELargeRequestCDC branch 3 times, most recently from 164c147 to bc0e853 Compare May 14, 2024 16:17
Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait force-pushed the E2ELargeRequestCDC branch from bc0e853 to c2d7337 Compare May 16, 2024 18:28
@peternied peternied merged commit a35d536 into opensearch-project:main May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants