Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: _update_by_query with a term. #451

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Jul 26, 2024

Description

The {index}/_update_by_query API also can take an arbitrary term per the docs.

What's the right fix for this? Removing additionalProperties with TermQuery doesn't seem right, but I'm not sure how to turn TermQuery into something generic at the same time as not.

          additionalProperties:
            $ref: '#/components/schemas/TermQuery'

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
524 118 (22.52 %)

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Changes Analysis

Commit SHA: e7af2d6
Comparing To SHA: aec3145

API Changes

Summary


└─┬Components
  ├─┬_common:ScriptBase
  │ └─┬params
  │   └──[🔀] additionalProperties (27877:33)❌ 
  └─┬_common.query_dsl:QueryContainer
    └─┬term
      └─┬Schema
        └──[🔀] $ref (36451:13)❌ 

Document Element Total Changes Breaking Changes
components 2 2
  • BREAKING Changes: 2 out of 2
  • Modifications: 2
  • Breaking Modifications: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/10149247240/artifacts/1752066459

API Coverage

Before After Δ
Covered (%) 500 (48.97 %) 500 (48.97 %) 0 (0 %)
Uncovered (%) 521 (51.03 %) 521 (51.03 %) 0 (0 %)
Unknown 24 24 0

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the update_by_query branch from 396fb97 to e7af2d6 Compare July 29, 2024 17:50
@dblock dblock marked this pull request as ready for review July 29, 2024 17:51
@nhtruong nhtruong merged commit 7cae0b8 into opensearch-project:main Jul 29, 2024
20 checks passed
@dblock dblock deleted the update_by_query branch July 29, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants