Fix: _update_by_query with a tem.

Signed-off-by: dblock <dblock@amazon.com>

spec/schemas/_common.query_dsl.yaml

@@ -181,8 +181,7 @@ components:
             Returns documents that contain an exact term in a provided field.
             To return a document, the query term must exactly match the queried field's value, including whitespace and capitalization.
           type: object
-          additionalProperties:
-            $ref: '#/components/schemas/TermQuery'
+          additionalProperties: true
           minProperties: 1
           maxProperties: 1
         terms:
@@ -1811,20 +1810,20 @@ components:
           required:
             - big
             - little
-    TermQuery:
-      allOf:
-        - $ref: '#/components/schemas/QueryBase'
-        - type: object
-          properties:
-            value:
-              $ref: '_common.yaml#/components/schemas/FieldValue'
-            case_insensitive:
-              description: |-
-                Allows ASCII case insensitive matching of the value with the indexed field values when set to `true`.
-                When `false`, the case sensitivity of matching depends on the underlying field's mapping.
-              type: boolean
-          required:
-            - value
+    # TermQuery:
+    #   allOf:
+    #     - $ref: '#/components/schemas/QueryBase'
+    #     - type: object
+    #       properties:
+    #         value:
+    #           $ref: '_common.yaml#/components/schemas/FieldValue'
+    #         case_insensitive:
+    #           description: |-
+    #             Allows ASCII case insensitive matching of the value with the indexed field values when set to `true`.
+    #             When `false`, the case sensitivity of matching depends on the underlying field's mapping.
+    #           type: boolean
+    #       required:
+    #         - value
     TermsQuery:
       allOf:
         - $ref: '#/components/schemas/QueryBase'

spec/schemas/_common.yaml

@@ -416,8 +416,7 @@ components:
             Specifies any named parameters that are passed into the script as variables.
             Use parameters instead of hard-coded values to decrease compile time.
           type: object
-          additionalProperties:
-            type: object
+          additionalProperties: true
     StoredScriptId:
       allOf:
         - $ref: '#/components/schemas/ScriptBase'

tests/_core/reindex.yaml

@@ -11,28 +11,7 @@ epilogues:
   - path: /videos
     method: DELETE
     status: [200, 404]
-  - path: /_ingest/pipeline/transform-and-count
-    method: DELETE
-    status: [200, 404]
 prologues:
-  - path: /_ingest/pipeline/transform-and-count
-    method: PUT
-    request_body:
-      payload:
-        description: |
-          Splits the `title`` field into a `words` list.
-          Computes the length of the title field and stores it in a new `length` field.
-          Removes the `year` field.
-        processors:
-          - split:
-              field: title
-              separator: '\s+'
-              target_field: words
-          - script:
-              lang: painless
-              source: ctx.length = ctx.words.length
-          - remove:
-              field: year
   - path: /{index}/_doc
     method: POST
     parameters:
@@ -135,56 +114,6 @@ chapters:
       status: 200
       payload:
         total: 1
-  - synopsis: Transform documents using a pipeline.
-    path: /_reindex
-    method: POST
-    request_body:
-      payload:
-        source:
-          index: movies
-        dest:
-          index: videos
-          pipeline: transform-and-count
-    response:
-      status: 200
-  - synopsis: Refresh the index.
-    path: /{index}/_refresh
-    method: POST
-    parameters:
-      index: videos
-  - synopsis: Get all videos.
-    path: /{index}/_search
-    method: POST
-    parameters:
-      index: videos
-    request_body:
-      payload:
-        query:
-          match_all: {}
-    response:
-      status: 200
-      payload:
-        hits:
-          hits:
-            - _index: videos
-              _source:
-                words:
-                  - Beauty
-                  - and
-                  - the
-                  # eslint-disable-next-line yml/sort-sequence-values
-                  - Beast
-                length: 4
-                title: Beauty and the Beast
-  - synopsis: Update documents in the current index.
-    path: /{index}/_update_by_query
-    method: POST
-    parameters:
-      index: videos
-    response:
-      status: 200
-      payload:
-        updated: 1
   - synopsis: Reindex from movies to films with all options.
     path: /_reindex
     method: POST

tests/_core/reindex/pipeline.yaml

@@ -0,0 +1,84 @@
+$schema: ../../../json_schemas/test_story.schema.yaml
+
+description: Test reindex with a Search pipeline.
+epilogues:
+  - path: /movies
+    method: DELETE
+    status: [200, 404]
+  - path: /videos
+    method: DELETE
+    status: [200, 404]
+  - path: /_ingest/pipeline/transform-and-count
+    method: DELETE
+    status: [200, 404]
+prologues:
+  - path: /_ingest/pipeline/transform-and-count
+    method: PUT
+    request_body:
+      payload:
+        description: |
+          Splits the `title`` field into a `words` list.
+          Computes the length of the title field and stores it in a new `length` field.
+          Removes the `year` field.
+        processors:
+          - split:
+              field: title
+              separator: '\s+'
+              target_field: words
+          - script:
+              lang: painless
+              source: ctx.length = ctx.words.length
+          - remove:
+              field: year
+  - path: /{index}/_doc
+    method: POST
+    parameters:
+      index: movies
+      refresh: true
+    request_body:
+      payload:
+        title: Beauty and the Beast
+        year: 91
+    status: [201]
+chapters:
+  - synopsis: Transform documents using a pipeline.
+    path: /_reindex
+    method: POST
+    request_body:
+      payload:
+        source:
+          index: movies
+        dest:
+          index: videos
+          pipeline: transform-and-count
+    response:
+      status: 200
+  - synopsis: Refresh the index.
+    path: /{index}/_refresh
+    method: POST
+    parameters:
+      index: videos
+  - synopsis: Get all videos.
+    path: /{index}/_search
+    method: POST
+    parameters:
+      index: videos
+    request_body:
+      payload:
+        query:
+          match_all: {}
+    response:
+      status: 200
+      payload:
+        hits:
+          hits:
+            - _index: videos
+              _source:
+                words:
+                  - Beauty
+                  - and
+                  - the
+                  # eslint-disable-next-line yml/sort-sequence-values
+                  - Beast
+                length: 4
+                title: Beauty and the Beast

tests/indices/update_by_query.yaml

@@ -0,0 +1,48 @@
+$schema: ../../json_schemas/test_story.schema.yaml
+
+description: Test reindex.
+epilogues:
+  - path: /movies
+    method: DELETE
+    status: [200, 404]
+prologues:
+  - path: /{index}/_doc
+    method: POST
+    parameters:
+      index: movies
+      refresh: true
+    request_body:
+      payload:
+        title: Beauty and the Beast
+        year: 91
+    status: [201]
+chapters:
+  - synopsis: Update documents in the index.
+    path: /{index}/_update_by_query
+    method: POST
+    parameters:
+      index: movies
+      refresh: true
+    response:
+      status: 200
+      payload:
+        updated: 1
+  - synopsis: Update documents in the index (script).
+    path: /{index}/_update_by_query
+    method: POST
+    parameters:
+      index: movies
+    request_body:
+      payload:
+        query:
+          term:
+            year: 91
+        script:
+          source: ctx._source.year += params.century
+          lang: painless
+          params:
+            century: 1900
+    response:
+      status: 200
+      payload:
+        updated: 1