Re-enable detekt #796
Merged
Re-enable detekt #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #796 +/- ##
=========================================
Coverage 66.85% 66.85%
Complexity 263 263
=========================================
Files 39 39
Lines 1738 1738
Branches 165 165
=========================================
Hits 1162 1162
Misses 453 453
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. |
xluo-aws
approved these changes
Oct 18, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-796-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0e55d38cbaa372265e444ca9107b6519b8b75c44
# Push it to GitHub
git push --set-upstream origin backport/backport-796-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.xThen, create a pull request where the |
|
@Noir01 would you mind to do manual backport for this PR? You can follow the steps listed in above comment |
rachana-dani
pushed a commit
to rachana-dani/notifications
that referenced
this pull request
Oct 19, 2023
Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com>
zhichao-aws
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> (cherry picked from commit 76ddcd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhichao-aws
pushed a commit
that referenced
this pull request
Oct 24, 2023
* Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> (cherry picked from commit 76ddcd4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Add slf4j-api for greenmail Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com>
Noir01
added a commit
to Noir01/notifications
that referenced
this pull request
Oct 25, 2023
Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> (cherry picked from commit 0e55d38)
xluo-aws
pushed a commit
that referenced
this pull request
Oct 30, 2023
Noir01
added a commit
to Noir01/notifications
that referenced
this pull request
Nov 13, 2023
* Add 2.11 release notes (opensearch-project#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (opensearch-project#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (opensearch-project#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (opensearch-project#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (opensearch-project#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu>
Noir01
added a commit
to Noir01/notifications
that referenced
this pull request
Nov 16, 2023
* Add 2.11 release notes (opensearch-project#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (opensearch-project#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (opensearch-project#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (opensearch-project#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (opensearch-project#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com>
zhichao-aws
added a commit
that referenced
this pull request
Nov 20, 2023
* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify integtest Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * update release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix wrong PR number Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert app id Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> --------- Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Remove slackId from domainIds Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation tests for Slack URL Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Format Signed-off-by: Aniruddh <ansriv2005@gmail.com> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh <aniruddh@purdue.edu> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Rachana Dani <36135368+rachana-dani@users.noreply.github.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify integtest Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * update release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix wrong PR number Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert app id Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> --------- Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Remove slackId from domainIds Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation tests for Slack URL Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Format Signed-off-by: Aniruddh <ansriv2005@gmail.com> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh <aniruddh@purdue.edu> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Rachana Dani <36135368+rachana-dani@users.noreply.github.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 87109a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Aug 23, 2024
* Microsoft teams (#676) * Added feature support for microsoft teams webhoo * Added feature support for microsoft teams webhook ,removed valid webhooks * Added feature support for Microsoft teams webhook * Refactored feature support for ms teams and added unit and integTest * fix build in core * fix core-spi build * fix notifications main code * fix mappings, add IT * add auto upgrade mapping logic * put load mapping to initialize step * add schema_version field * add integ test * adjust with auto upgrade mapping logic * add bwc * modify bwc * modify bwc * resolve comments * add license header * fix microsoft teams sample url in IT to adapt url validation --------- * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams * modify integtest --------- * onboard system and hidden index (#742) * Updates demo certs used in integ tests (#756) * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes * update release notes * Update opensearch-notifications.release-notes-2.10.0.0.md * fix wrong PR number --------- * bump bwc version to 2.11 (#763) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Impove security plugin enabling check (#792) * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow * revert app id --------- * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Replace the TestMailServer to GreenMail server * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * Add assertion for retrieval of notification * Update to stable version * Update to stable version * Update to suggested version --------- * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions * Add more --------- * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. * Undid 80fc198 Removed slf4j-jdk14.jar from classpath * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath --------- * Added Slack webhook URL validation regex * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replace path of mock Slack URL with `sample_slack_url` * Remove slackId from domainIds * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Add tests for wrong Slack URLs * Add validation tests for Slack URL * Format * GovSlack apps can use the slack-gov.com domain * Add validation for gov-slack.com domain --------- (cherry picked from commit 87109a0) Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Rachana Dani <36135368+rachana-dani@users.noreply.github.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that detekt no longer depends on a vulnerable version of snakeyaml, it can be safely re-enabled.
Description
Undid #528
Issues Resolved
Fix #529
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.