Microsoft teams #676

zhichao-aws · 2023-05-15T03:31:43Z

Description

add Microsoft Teams as notification channel type

Issues Resolved

Check List

Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: danielkyalo599 <johbiento@gmail.com>

…ooks Signed-off-by: danielkyalo599 <johbiento@gmail.com>

Signed-off-by: danielkyalo599 <johbiento@gmail.com>

…crosoft_teams Signed-off-by: zhichao-aws <zhichaog@amazon.com>

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

zhichao-aws · 2023-05-15T10:11:43Z

PR in common-utils: opensearch-project/common-utils#428

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

zhichao-aws · 2023-08-09T02:44:54Z

tests depending on the PR in common-utils opensearch-project/common-utils#428

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

codecov · 2023-08-21T02:37:53Z

Codecov Report

Merging #676 (18c8af1) into main (1cd4263) will increase coverage by 0.25%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #676      +/-   ##
============================================
+ Coverage     66.27%   66.53%   +0.25%     
- Complexity      257      262       +5     
============================================
  Files            39       39              
  Lines          1720     1733      +13     
  Branches        165      165              
============================================
+ Hits           1140     1153      +13     
  Misses          457      457              
  Partials        123      123

Flag	Coverage Δ
opensearch-notifications	`66.53% <100.00%> (+0.25%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...org/opensearch/notifications/NotificationPlugin.kt	`97.43% <ø> (ø)`
...fications/action/CreateNotificationConfigAction.kt	`81.81% <ø> (ø)`
...fications/action/DeleteNotificationConfigAction.kt	`81.81% <ø> (ø)`
...earch/notifications/action/GetChannelListAction.kt	`81.81% <ø> (ø)`
...otifications/action/GetNotificationConfigAction.kt	`81.81% <ø> (ø)`
...ch/notifications/action/GetPluginFeaturesAction.kt	`84.61% <ø> (ø)`
...pensearch/notifications/action/PluginBaseAction.kt	`43.93% <ø> (ø)`
.../notifications/action/PublishNotificationAction.kt	`72.72% <ø> (ø)`
...rch/notifications/action/SendNotificationAction.kt	`81.81% <ø> (ø)`
...notifications/action/SendTestNotificationAction.kt	`100.00% <ø> (ø)`
... and 8 more

...tions/core/src/main/kotlin/org/opensearch/notifications/core/client/DestinationHttpClient.kt

...ns/notifications/src/main/kotlin/org/opensearch/notifications/index/ConfigIndexingActions.kt

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

yuye-aws

Looks good to me!

gaobinlong

LGTM.

* Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> (cherry picked from commit 8c8a6b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> (cherry picked from commit 8c8a6b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * adapt to 2.x httpcomponents version Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com>

* Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify integtest Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * update release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix wrong PR number Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert app id Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> --------- Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Remove slackId from domainIds Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation tests for Slack URL Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Format Signed-off-by: Aniruddh <ansriv2005@gmail.com> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh <aniruddh@purdue.edu> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Rachana Dani <36135368+rachana-dani@users.noreply.github.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <johbiento@gmail.com> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <johbiento@gmail.com> * fix build in core Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix core-spi build Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix notifications main code Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix mappings, add IT Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * put load mapping to initialize step Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add schema_version field Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add integ test Signed-off-by: zhichao-aws <zhichaog@amazon.com> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify bwc Signed-off-by: zhichao-aws <zhichaog@amazon.com> * resolve comments Signed-off-by: zhichao-aws <zhichaog@amazon.com> * add license header Signed-off-by: zhichao-aws <zhichaog@amazon.com> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <zhichaog@amazon.com> * modify integtest Signed-off-by: zhichao-aws <zhichaog@amazon.com> --------- Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * update release notes Signed-off-by: Hailong Cui <ihailong@amazon.com> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix wrong PR number Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <ihailong@amazon.com> * revert app id Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Add assertion for retrieval of notification Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to stable version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> * Update to suggested version Signed-off-by: rdani <rachana_sudhindradani@intuit.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Add more Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> --------- Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Remove slackId from domainIds Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation tests for Slack URL Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Format Signed-off-by: Aniruddh <ansriv2005@gmail.com> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <ansriv2005@gmail.com> --------- Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh <aniruddh@purdue.edu> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Rachana Dani <36135368+rachana-dani@users.noreply.github.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com> (cherry picked from commit 87109a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Microsoft teams (#676) * Added feature support for microsoft teams webhoo * Added feature support for microsoft teams webhook ,removed valid webhooks * Added feature support for Microsoft teams webhook * Refactored feature support for ms teams and added unit and integTest * fix build in core * fix core-spi build * fix notifications main code * fix mappings, add IT * add auto upgrade mapping logic * put load mapping to initialize step * add schema_version field * add integ test * adjust with auto upgrade mapping logic * add bwc * modify bwc * modify bwc * resolve comments * add license header * fix microsoft teams sample url in IT to adapt url validation --------- * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams * modify integtest --------- * onboard system and hidden index (#742) * Updates demo certs used in integ tests (#756) * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes * update release notes * Update opensearch-notifications.release-notes-2.10.0.0.md * fix wrong PR number --------- * bump bwc version to 2.11 (#763) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Impove security plugin enabling check (#792) * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow * revert app id --------- * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning * Fix bwc test failure of throwing direct access to system index when getting mapping --------- * Replace the TestMailServer to GreenMail server * bump bwc version to 2.12 (#793) * Update dependency org.json:json to v20231013 (#795) * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` * Add assertion for retrieval of notification * Update to stable version * Update to stable version * Update to suggested version --------- * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions * Add more --------- * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. * Undid 80fc198 Removed slf4j-jdk14.jar from classpath * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath --------- * Added Slack webhook URL validation regex * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Replace path of mock Slack URL with `sample_slack_url` * Remove slackId from domainIds * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL * Add tests for wrong Slack URLs * Add validation tests for Slack URL * Format * GovSlack apps can use the slack-gov.com domain * Add validation for gov-slack.com domain --------- (cherry picked from commit 87109a0) Signed-off-by: danielkyalo599 <johbiento@gmail.com> Signed-off-by: zhichao-aws <zhichaog@amazon.com> Signed-off-by: Aniruddh <ansriv2005@gmail.com> Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu> Signed-off-by: Aniruddh <63553175+Noir01@users.noreply.github.com> Signed-off-by: rdani <rachana_sudhindradani@intuit.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Signed-off-by: Noir <63553175+Noir01@users.noreply.github.com> Signed-off-by: Aniruddh Srivastava <ansriv2005@gmail.com> Signed-off-by: Aniruddh <aniruddh@purdue.edu> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <zhichaog@amazon.com> Co-authored-by: danielkyalo599 <johbiento@gmail.com> Co-authored-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Darshit Chanpura <35282393+DarshitChanpura@users.noreply.github.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: Rachana Dani <36135368+rachana-dani@users.noreply.github.com> Co-authored-by: rdani <rachana_sudhindradani@intuit.com> Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>

dankyalo599 and others added 7 commits February 10, 2023 19:53

Added feature support for microsoft teams webhoo

add210b

Signed-off-by: danielkyalo599 <johbiento@gmail.com>

Added feature support for microsoft teams webhook ,removed valid webh…

6845949

…ooks Signed-off-by: danielkyalo599 <johbiento@gmail.com>

Added feature support for Microsoft teams webhook

077fd85

Signed-off-by: danielkyalo599 <johbiento@gmail.com>

Refactored feature support for ms teams and added unit and integTest

5a0196f

Signed-off-by: danielkyalo599 <johbiento@gmail.com>

Merge remote-tracking branch 'dankyalo599/Add_unit_integTest' into mi…

edbc3ce

…crosoft_teams Signed-off-by: zhichao-aws <zhichaog@amazon.com>

fix build in core

93dc458

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

fix core-spi build

b5cc50d

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

This was referenced May 15, 2023

Added common utils for microsoft teams opensearch-project/common-utils#374

Closed

common utils to support Microsoft teams in notifications opensearch-project/common-utils#428

Merged

zhichao-aws added 2 commits May 15, 2023 18:24

fix notifications main code

3e717e1

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

fix mappings, add IT

4c07241

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

zhichao-aws marked this pull request as ready for review May 16, 2023 03:40

zhichao-aws requested review from xluo-aws, gaobinlong, Hailong-am, SuZhou-Joe, yuye-aws and zhongnansu as code owners May 16, 2023 03:40

zhichao-aws mentioned this pull request May 16, 2023

Add unit integ test for feature support ms teams #638

Closed

zhichao-aws marked this pull request as draft May 23, 2023 09:02

zhichao-aws added 9 commits July 3, 2023 14:51

add auto upgrade mapping logic

28c403f

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

put load mapping to initialize step

02e1e76

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

add schema_version field

5ff36e3

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

add integ test

fe478b2

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

Merge branch 'main' into microsoft_teams

9ab78f6

Merge branch 'auto_upgrade_mappings' into microsoft_teams

89fc8b6

adjust with auto upgrade mapping logic

99893a2

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

add bwc

8d874c5

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

Merge branch 'main' into microsoft_teams

308589a

modify bwc

08aa837

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

zhichao-aws marked this pull request as ready for review August 9, 2023 02:42

zhichao-aws added the backport 2.x label Aug 16, 2023

zhichao-aws self-assigned this Aug 16, 2023

zhichao-aws added the v2.10.0 label Aug 16, 2023

zhichao-aws added 2 commits August 16, 2023 13:03

Merge branch 'main' into microsoft_teams

35ca106

modify bwc

0c2883c

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

xluo-aws reviewed Aug 23, 2023

View reviewed changes

...tions/core/src/main/kotlin/org/opensearch/notifications/core/client/DestinationHttpClient.kt Outdated Show resolved Hide resolved

xluo-aws reviewed Aug 23, 2023

View reviewed changes

...ns/notifications/src/main/kotlin/org/opensearch/notifications/index/ConfigIndexingActions.kt Outdated Show resolved Hide resolved

zhichao-aws added 2 commits August 24, 2023 10:33

resolve comments

f13e1f8

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

add license header

c330a1c

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

xluo-aws previously approved these changes Aug 24, 2023

View reviewed changes

fix microsoft teams sample url in IT to adapt url validation

18c8af1

Signed-off-by: zhichao-aws <zhichaog@amazon.com>

zhichao-aws dismissed xluo-aws’s stale review via 18c8af1 August 24, 2023 03:19

zhichao-aws requested a review from xluo-aws August 24, 2023 03:42

xluo-aws approved these changes Aug 24, 2023

View reviewed changes

yuye-aws reviewed Aug 24, 2023

View reviewed changes

yuye-aws approved these changes Aug 24, 2023

View reviewed changes

gaobinlong approved these changes Aug 24, 2023

View reviewed changes

zhichao-aws merged commit 8c8a6b6 into opensearch-project:main Aug 24, 2023

opensearch-trigger-bot bot mentioned this pull request Aug 24, 2023

[Backport 2.x] Microsoft teams #745

Merged

zhichao-aws mentioned this pull request Aug 25, 2023

[FEATURE] Add Microsoft Teams to supported channel types opensearch-project/alerting-dashboards-plugin#692

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft teams #676

Microsoft teams #676

zhichao-aws commented May 15, 2023

zhichao-aws commented May 15, 2023

zhichao-aws commented Aug 9, 2023

codecov bot commented Aug 21, 2023 •

edited

Loading

yuye-aws left a comment

gaobinlong left a comment

Microsoft teams #676

Microsoft teams #676

Conversation

zhichao-aws commented May 15, 2023

Description

Issues Resolved

Check List

zhichao-aws commented May 15, 2023

zhichao-aws commented Aug 9, 2023

codecov bot commented Aug 21, 2023 • edited Loading

Codecov Report

yuye-aws left a comment

Choose a reason for hiding this comment

gaobinlong left a comment

Choose a reason for hiding this comment

codecov bot commented Aug 21, 2023 •

edited

Loading