[Backport 2.3] Support SNS FIFO queues (#716) #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support SNS FIFO queues Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * use clusterService.clusterName when applicable Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> * fix unit tests Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> --------- Signed-off-by: Ashish Agrawal <ashisagr@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Codecov Report
@@ Coverage Diff @@
## 2.3 #726 +/- ##
============================================
- Coverage 70.74% 61.22% -9.52%
- Complexity 112 113 +1
============================================
Files 124 73 -51
Lines 3951 2486 -1465
Branches 630 268 -362
============================================
- Hits 2795 1522 -1273
+ Misses 976 785 -191
+ Partials 180 179 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hailong-am
approved these changes
Jul 26, 2023
gaobinlong
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 58a7578 from #716.