Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SNS FIFO queues #716

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Jul 19, 2023

Description

Support SNS FIFO queues

Issues Resolved

#715

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago
Copy link
Member Author

lezzago commented Jul 19, 2023

Failing tests are due to BWC failure that have been existing.

Hailong-am
Hailong-am previously approved these changes Jul 21, 2023
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have few unit test failed, need fix failed unit test first.

lezzago added 3 commits July 25, 2023 08:43
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #716 (1ebdc97) into main (d0a322c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #716   +/-   ##
=========================================
  Coverage     66.19%   66.19%           
  Complexity      253      253           
=========================================
  Files            39       39           
  Lines          1698     1698           
  Branches        158      158           
=========================================
  Hits           1124     1124           
  Misses          456      456           
  Partials        118      118           
Flag Coverage Δ
opensearch-notifications 66.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Hailong-am Hailong-am merged commit 58a7578 into opensearch-project:main Jul 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* use clusterService.clusterName when applicable

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix unit tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
(cherry picked from commit 58a7578)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.3 2.3
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.3
# Create a new branch
git switch --create backport/backport-716-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58a7578e0ca7a599465f84fd4845f8fcd0a72b8b
# Push it to GitHub
git push --set-upstream origin backport/backport-716-to-2.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.3

Then, create a pull request where the base branch is 2.3 and the compare/head branch is backport/backport-716-to-2.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.5 2.5
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.5
# Create a new branch
git switch --create backport/backport-716-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58a7578e0ca7a599465f84fd4845f8fcd0a72b8b
# Push it to GitHub
git push --set-upstream origin backport/backport-716-to-2.5
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.5

Then, create a pull request where the base branch is 2.5 and the compare/head branch is backport/backport-716-to-2.5.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.9 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.9 2.9
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.9
# Create a new branch
git switch --create backport/backport-716-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58a7578e0ca7a599465f84fd4845f8fcd0a72b8b
# Push it to GitHub
git push --set-upstream origin backport/backport-716-to-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.9

Then, create a pull request where the base branch is 2.9 and the compare/head branch is backport/backport-716-to-2.9.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.7 2.7
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.7
# Create a new branch
git switch --create backport/backport-716-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 58a7578e0ca7a599465f84fd4845f8fcd0a72b8b
# Push it to GitHub
git push --set-upstream origin backport/backport-716-to-2.7
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.7

Then, create a pull request where the base branch is 2.7 and the compare/head branch is backport/backport-716-to-2.7.

lezzago added a commit to lezzago/notifications that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* use clusterService.clusterName when applicable

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix unit tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
lezzago added a commit to lezzago/notifications that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* use clusterService.clusterName when applicable

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix unit tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
lezzago added a commit to lezzago/notifications that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* use clusterService.clusterName when applicable

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix unit tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
lezzago added a commit to lezzago/notifications that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* use clusterService.clusterName when applicable

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix unit tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Hailong-am added a commit that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues



* use clusterService.clusterName when applicable



* fix unit tests



---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Hailong-am added a commit that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues



* use clusterService.clusterName when applicable



* fix unit tests



---------



(cherry picked from commit 58a7578)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
gaobinlong pushed a commit that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues



* use clusterService.clusterName when applicable



* fix unit tests



---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Hailong-am added a commit that referenced this pull request Jul 26, 2023
* Support SNS FIFO queues



* use clusterService.clusterName when applicable



* fix unit tests



---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Hailong-am added a commit to lezzago/notifications that referenced this pull request Jul 27, 2023
* Support SNS FIFO queues

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* use clusterService.clusterName when applicable

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* fix unit tests

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
gaobinlong pushed a commit that referenced this pull request Jul 27, 2023
* Support SNS FIFO queues



* use clusterService.clusterName when applicable



* fix unit tests



---------

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants