[Backport 2.x] Remove overallocation in faiss query path #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes overallocation of 2 c++ vectors in faiss querying functionality. Performance results can be viewed in [497](#497 (comment)). In general, this change could provide a small improvement in memory footprint during search workloads. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 507bafe)
jmazanec15
approved these changes
Aug 8, 2022
|
Just to make sure - we already cut 2.2 and no code will go there from 2.x branch, correct? |
|
@martin-gaievski yes thats correct. |
martin-gaievski
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 507bafe from #501