Remove overallocation in faiss query path #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes overallocation of 2 c++ vectors in faiss querying functionality. Performance results can be viewed in [497](opensearch-project#497 (comment)). In general, this change could provide a small improvement in memory footprint during search workloads. Signed-off-by: John Mazanec <jmazane@amazon.com>
navneet1v
reviewed
Aug 8, 2022
Comment on lines
+195
to
+196
| std::vector<float> dis(kJ); | ||
| std::vector<faiss::Index::idx_t> ids(kJ); |
There was a problem hiding this comment.
add a comment on top of this change what it is doing and why it is required.
Codecov Report
@@ Coverage Diff @@
## main #501 +/- ##
=========================================
Coverage 84.04% 84.04%
Complexity 1019 1019
=========================================
Files 146 146
Lines 4188 4188
Branches 373 373
=========================================
Hits 3520 3520
Misses 492 492
Partials 176 176 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: John Mazanec <jmazane@amazon.com>
martin-gaievski
approved these changes
Aug 8, 2022
navneet1v
approved these changes
Aug 8, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2022
Removes overallocation of 2 c++ vectors in faiss querying functionality. Performance results can be viewed in [497](#497 (comment)). In general, this change could provide a small improvement in memory footprint during search workloads. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 507bafe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes overallocation of 2 c++ vectors in faiss querying functionality.
Performance results can be viewed in 497.
In general, this change could provide a small improvement in memory
footprint during search workloads.
Issues Resolved
#497
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.