Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Show data streams in 'Indices' and 'Managed Indices' sections #24

Merged
merged 8 commits into from
Jul 1, 2021

Conversation

ketanv3
Copy link
Contributor

@ketanv3 ketanv3 commented Jun 3, 2021

Description

  • Added an additional column to show the name of the parent data stream.
  • Added a toggle switch to show/hide indices belonging to a data stream.
  • Added a multi-select drop-down to easily filter indices belonging to one or more data streams.
  • Disabled 'Edit Rollover Alias' option when managing the backing index of a data stream.
  • Removed redundant pagination options from top of the table to allow space for other options.

Issues Resolved

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ketan Verma ketan9495@gmail.com

@ketanv3 ketanv3 force-pushed the feature/22 branch 2 times, most recently from e449384 to 7890691 Compare June 3, 2021 21:34
@ketanv3 ketanv3 marked this pull request as ready for review June 3, 2021 21:59
@bowenlan-amzn
Copy link
Member

bowenlan-amzn commented Jun 4, 2021

This change was not into our rc1 release.

Copy link
Contributor

@thalurur thalurur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like rollup/transform creation worklow doesn't support datastream as source index, should this PR address this?

@ketanv3 ketanv3 force-pushed the feature/22 branch 2 times, most recently from 8799f30 to ae791d7 Compare June 17, 2021 07:56
@ketanv3
Copy link
Contributor Author

ketanv3 commented Jun 17, 2021

@thalurur Thanks for calling this out. I have now populated the the 'source index' multi-select with the list of data streams in both rollup and transform job creation flows.

Copy link
Contributor

@thalurur thalurur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we need horizontal scroll on the datastream drop down to show long names? image

ketanv3 added 8 commits June 25, 2021 23:40
…_streams in search queries.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
It adds a data stream column, toggle switch to show/hide data stream indices, and multi-select drop-down to select backing indices of one or more data streams.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
…pace for other options.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
…lows.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
… multiple awaits.

Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
@ketanv3
Copy link
Contributor Author

ketanv3 commented Jun 25, 2021

@thalurur
This drop-down selection is a filter that's a part of the SearchBar component in EUI. This filter doesn't support horizontal scrolling for very long names.

I have now added Jest/Cypress tests for any new functionality that's introduced.

Copy link
Contributor

@annie3431 annie3431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@thalurur thalurur merged commit 0a71575 into opensearch-project:main Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Show data streams in 'Indices' and 'Managed Indices' sections
4 participants