-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Show data streams in 'Indices' and 'Managed Indices' sections #24
Conversation
e449384
to
7890691
Compare
This change was not into our rc1 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like rollup/transform creation worklow doesn't support datastream as source index, should this PR address this?
8799f30
to
ae791d7
Compare
@thalurur Thanks for calling this out. I have now populated the the 'source index' multi-select with the list of data streams in both rollup and transform job creation flows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…_streams in search queries. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
It adds a data stream column, toggle switch to show/hide data stream indices, and multi-select drop-down to select backing indices of one or more data streams. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
…pace for other options. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
…lows. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
… multiple awaits. Signed-off-by: Ketan Verma <ketan9495@gmail.com>
Signed-off-by: Ketan Verma <ketan9495@gmail.com>
@thalurur I have now added Jest/Cypress tests for any new functionality that's introduced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Description
Issues Resolved
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Signed-off-by: Ketan Verma ketan9495@gmail.com