-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document client certificate options to support mutual TLS for OpenID endpoint #5697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endpoint. Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com>
3 tasks
cwperks
approved these changes
Nov 30, 2023
Thanks for submitting this PR, @Simple-Analysis ! And thanks for your review @cwperks. @Naarcha-AWS - can you please give it a doc review and get it merged? Looks like this fix addresses #1499 and #786. |
Naarcha-AWS
requested changes
Dec 1, 2023
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com>
Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com>
Naarcha-AWS
approved these changes
Dec 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…endpoint (#5697) * Document client certificate options to support mutual TLS for OpenID endpoint. Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> --------- Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> (cherry picked from commit 21f8a61) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Naarcha-AWS
added a commit
that referenced
this pull request
Dec 5, 2023
…endpoint (#5697) (#5789) * Document client certificate options to support mutual TLS for OpenID endpoint. * Update _security/authentication-backends/openid-connect.md * Update _security/authentication-backends/openid-connect.md * Update _security/authentication-backends/openid-connect.md --------- (cherry picked from commit 21f8a61) Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
4 tasks
vagimeli
pushed a commit
that referenced
this pull request
Dec 21, 2023
…endpoint (#5697) * Document client certificate options to support mutual TLS for OpenID endpoint. Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> * Update _security/authentication-backends/openid-connect.md Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> --------- Signed-off-by: Calvin Harrison <74850112+Simple-Analysis@users.noreply.github.com> Signed-off-by: Simple-Analysis <74850112+Simple-Analysis@users.noreply.github.com> Co-authored-by: Naarcha-AWS <97990722+Naarcha-AWS@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users can configure options to enable mutual TLS when obtaining OpenID Connect endpoints from IdP.
Issues Resolved
Relates to:
opensearch-project/security-dashboards-plugin#1650
Fixes #786
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.