Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Plugin] The root_ca property for Open ID configurations isn't documented #786

Closed
zehonghuang opened this issue Jul 8, 2022 · 13 comments · Fixed by #5697
Closed
Assignees
Labels
2 - In progress Issue/PR: The issue or PR is in progress. security

Comments

@zehonghuang
Copy link

zehonghuang commented Jul 8, 2022

https://github.com/opensearch-project/security-dashboards-plugin/blob/5e4004fbb7195f5a5f9f7ded14ea7ea49dadecaa/server/auth/types/openid/openid_auth.ts#L115

I have expended efforts to solve just because this.config.openid.root_ca display no in documentnation.
Using https keycloak-openid maybe occur OpenId authentication failed: Error: Client request error: unable to get issuer certificate.

So, Please Update doc !

@peternied
Copy link
Member

thanks for filing this issue, I'm moving this to the documentation repo where it can be updated, if you'd like to update the documentation around Open ID see openid-connect.md, we would be happy to review a pull request.

@peternied peternied transferred this issue from opensearch-project/security-dashboards-plugin Jul 8, 2022
@peternied peternied added untriaged xx-documentation Improvements or additions to documentation labels Jul 8, 2022
@peternied peternied changed the title Documentation is dated ?! Please Update that. [Security Plugin] The root_ca property for Open ID configurations isn't documented Jul 8, 2022
@Naarcha-AWS Naarcha-AWS added this to the 2022-Q3 milestone Jul 11, 2022
@Naarcha-AWS Naarcha-AWS assigned cwillum and unassigned JeffHuss Jul 11, 2022
@JeffHuss JeffHuss added the 1 - Backlog Issue: The issue is unassigned or assigned but not started label Jul 11, 2022
@cwillum
Copy link
Contributor

cwillum commented Jul 12, 2022

@opensearch-project/security Could someone weigh in and provide a description for this property? Then we'll get it into documentation. Thanks.

@peternied
Copy link
Member

Based on the name and usage, its a path to a root certification authority file, in a pem format. AFAIK it should follow the same usage patterns we have in security around other root CA certificates. See additional background from https://opensearch.org/docs/latest/dashboards/install/tls/ that looks like it should align with this usage.

@cwillum
Copy link
Contributor

cwillum commented Jul 13, 2022

If this property is used for certificate validation using OpenID, it's not clear to me how root_ca would differ from pemtrustedcas_filepath (described as "Absolute path to the PEM file containing the root CAs of your IdP."). Should root_ca specify a different path?

@zehonghuang
Copy link
Author

If this property is used for certificate validation using OpenID, it's not clear to me how root_ca would differ from pemtrustedcas_filepath (described as "Absolute path to the PEM file containing the root CAs of your IdP."). Should root_ca specify a different path?

Actually, they are the same file, but used in different places. Kibana verify OpenID TLS with root_ca.

@cwillum
Copy link
Contributor

cwillum commented Jul 13, 2022

@zehonghuang Thanks for the reply and additional information. I just wanted to confirm that you're using root_ca to specify the path to the root CA with Kibana. Do you agree that pemtrustedcas_filepath should accomplish the same for Dashboards?

@zehonghuang
Copy link
Author

I think names should at least be consistent, and documented. :p

@cwillum
Copy link
Contributor

cwillum commented Jul 14, 2022

@opensearch-project/security I've looked into this a little more. The pemtrustedcas_filepath property is pretty well established syntax for specifying the "Absolute path to the PEM file containing the root CAs of your IdP" in OpenID for TLS settings (as well as SAML). I'm beginning to wonder if root_ca might be a configuration property specifying the same but related to client certificates. If so, I'm still not sure when/how it is used. And I may be barking up the wrong tree anyhow. Could the reference in the openid_auth.ts file, #L115 shed more light on this?

@peternied
Copy link
Member

@cwillum I've started a discussion to try to get help looking into this issue, follow up at https://github.com/orgs/opensearch-project/teams/security/discussions/3

@hdhalter hdhalter removed the xx-documentation Improvements or additions to documentation label Aug 29, 2022
@hdhalter
Copy link
Contributor

Hi @peternied - did you find any resolution to this issue? I can't access the above link, so not sure if there was any discussion about this. Thanks!

@peternied
Copy link
Member

I can't find it either, looks like that was deleated. Can we document the setting for root_ca like we've documented the other dashboards settings. Looks like we can existing description for pemtrustedcas_filepath as a good starting point.

@hdhalter
Copy link
Contributor

Sounds good! Can you please update the file with the description? And would it go here: https://opensearch.org/docs/latest/install-and-configure/configuring-opensearch/security-settings/?

@peternied
Copy link
Member

@derek-ho Would you mind taking a look at making this change?

@hdhalter hdhalter assigned derek-ho and unassigned cwillum Nov 30, 2023
@hdhalter hdhalter added 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed 1 - Backlog Issue: The issue is unassigned or assigned but not started labels Nov 30, 2023
@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Dec 5, 2023
@hdhalter hdhalter removed this from the 2022-Q3 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In progress Issue/PR: The issue or PR is in progress. security
Projects
None yet
7 participants