Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Integrations integration tests #1242

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Nov 13, 2023

Description

Updates outdated integration tests identified in #1039 to work with the new integrations UI. This PR restores 4 broken tests.

Issues Resolved

Resolves #1039

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7efbd4) 44.08% compared to head (5b55a04) 44.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
- Coverage   44.08%   44.06%   -0.03%     
==========================================
  Files         329      329              
  Lines       19682    19682              
  Branches     4687     4685       -2     
==========================================
- Hits         8677     8673       -4     
- Misses      10960    10964       +4     
  Partials       45       45              
Flag Coverage Δ
dashboards-observability 44.06% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiddis Swiddis added the integrations Used to denote items related to the Integrations project label Nov 14, 2023
@Swiddis Swiddis merged commit e9a0674 into opensearch-project:main Nov 22, 2023
@Swiddis Swiddis deleted the fix-integrations-integration branch November 22, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Used to denote items related to the Integrations project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Outdated Cypress tests in 9_integrations
3 participants